Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEATURE: Add gat command #781

Closed
wants to merge 1 commit into from
Closed

FEATURE: Add gat command #781

wants to merge 1 commit into from

Conversation

cheesecrust
Copy link

add get and touch command

๐Ÿ”— Related Issue

โŒจ๏ธ What I did

  • gat, gats command ์ถ”๊ฐ€ (memecached ์˜ ๊ตฌํ˜„๊ณผ ์œ ์‚ฌํ•˜๊ฒŒ get_command ์— ์ถ”๊ฐ€์ ์œผ๋กœ ๊ตฌ์„ฑํ•˜์˜€์Šต๋‹ˆ๋‹ค.)
  • gat test file ์ถ”๊ฐ€
  • doc ์ถ”๊ฐ€ (์šฐ์„  ch04 ์— ์ถ”๊ฐ€ํ•˜์˜€๋Š”๋ฐ, ํ–ฅํ›„ ์ถ”๊ฐ€๋  ๊ณณ์ด ํ™•์ •๋˜๋ฉด ์˜ฎ๊ธฐ๋„๋ก ํ•˜๊ฒ ์Šต๋‹ˆ๋‹ค.)

@ing-eoking ing-eoking requested review from namsic and ing-eoking July 29, 2024 05:02
namsic
namsic reviewed Jul 30, 2024
View reviewed changes
docs/ascii-protocol/ch04-command-key-value.md Outdated Show resolved Hide resolved
memcached.c Outdated Show resolved Hide resolved
@cheesecrust cheesecrust force-pushed the feat/#487-gat branch 2 times, most recently from c22df00 to fcf5ad0 Compare July 31, 2024 02:48
@cheesecrust cheesecrust marked this pull request as draft August 1, 2024 01:28
cheesecrust
cheesecrust commented Aug 1, 2024
View reviewed changes
memcached.c Outdated Show resolved Hide resolved
@cheesecrust cheesecrust force-pushed the feat/#487-gat branch 2 times, most recently from f74c376 to 89ddedb Compare August 1, 2024 02:29
@cheesecrust cheesecrust marked this pull request as ready for review August 1, 2024 02:37
ing-eoking
ing-eoking reviewed Aug 1, 2024
View reviewed changes
memcached.c Outdated Show resolved Hide resolved
memcached.c Outdated Show resolved Hide resolved
@cheesecrust cheesecrust force-pushed the feat/#487-gat branch 5 times, most recently from 9eec69b to 89baec4 Compare August 2, 2024 00:48
@cheesecrust
FEATURE: Add gat command
89baec4 
add get and touch command
namsic
namsic reviewed Aug 2, 2024
View reviewed changes
memcached.c Show resolved Hide resolved
@namsic
Copy link
Collaborator

namsic commented Dec 30, 2024

cheesecrust/arcus-memcached์˜ feat/#487-gat branch๋Š”
naver/arcus-memcached์˜ cheesecrust/gat branch๋กœ ๋ฐฑ์—…ํ•ด ๋‘์—ˆ์Šต๋‹ˆ๋‹ค.

์ดํ›„ ๋ฆด๋ฆฌ์ฆˆ ์‹œ์ ์— gat ๋ช…๋ น ์ถ”๊ฐ€๋ฅผ ๋‹ค์‹œ ๋‹ค๋ฃจ๋Š” ๊ฒƒ์œผ๋กœ ํ•˜๊ณ , ํ˜„์žฌ๋Š” PR ๋‹ซ์Šต๋‹ˆ๋‹ค.

@namsic namsic closed this Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@namsic namsic namsic left review comments

@ing-eoking ing-eoking ing-eoking approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cheesecrust @namsic @ing-eoking