Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Make possible to test issue_67 even in root user #695

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

ing-eoking
Copy link
Collaborator

해당 PR 작업 중 발견된 버그 사항을 분리합니다.

root 권한으로 make test 수행 중 67번 테스트가 실패하는 상황을 수정합니다.

Copy link
Collaborator

@jhpark816 jhpark816 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 완료

@@ -38,6 +38,10 @@ sub validate_port {
sub run_server {
my ($args) = @_;

if ($< == 0) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if 조건은 어떤 의미인가요?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$<는 USER ID를 의미하며,
0인 경우는 root를 의미합니다.

@jhpark816 jhpark816 merged commit 4b5e3b8 into naver:develop Oct 19, 2023
1 check passed
@ing-eoking ing-eoking deleted the develop-test branch November 2, 2023 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants