REFACTOR: remove unused getMaxPipeCount. #853
Conversation
| @@ -145,7 +146,7 @@ void testMaxPipedExist() { | |||
| List<Object> findValues = new ArrayList<>(); | |||
|
|
|||
| // insert items | |||
| for (int i = 0; i < mc.getMaxPipedItemCount(); i++) { | |||
| for (int i = 0; i < CollectionPipedInsert.MAX_PIPED_ITEM_COUNT; i++) { | |||
There was a problem hiding this comment.
SetPipedExist.MAX_PIPED_ITEM_COUNTλ‘ λ³κ²½νλ κ²μ΄ λ§μ κ² κ°μ΅λλ€.
There was a problem hiding this comment.
λ³κ²½νμ§ μμ μ΄μ λ₯Ό μλ €μ£ΌμΈμ.
| @@ -41,7 +42,7 @@ class MopBulkAPITest extends BaseIntegrationTest { | |||
| private final Map<String, Object> updateMap = new HashMap<>(); | |||
|
|
|||
| private int getValueCount() { | |||
| return mc.getMaxPipedItemCount(); | |||
| return CollectionPipedInsert.MAX_PIPED_ITEM_COUNT; | |||
There was a problem hiding this comment.
CollectionPipedInsert.MAX_PIPED_ITEM_COUNT μΈμλ
CollectionPipedUpdate.MAX_PIPED_ITEM_COUNT κ°μ΄ μμ΅λλ€.
ν μ€νΈ λ‘μ§μμ λ κ° μ€ μ΄λ€ κ°μ μ¬μ©ν΄μΌ νλ μ§λ κ²ν ν΄ λ³΄μμ£ .
There was a problem hiding this comment.
- CollectionPipedInsert.MAX_PIPED_ITEM_COUNT
- CollectionPipedUpdate.MAX_PIPED_ITEM_COUNT
- SetPipedExist.MAX_PIPED_ITEM_COUNT
μ λ€ λμΌνκ² 500μΌλ‘ μ€μ λμ΄μμ΅λλ€.
There was a problem hiding this comment.
μ λ€ λμΌνκ² 500μΌλ‘ μ€μ λμ΄μμ΅λλ€.
μμ μ΄μ κ°
CollectionPipedInsert.MAX_PIPED_ITEM_COUNT κ°μ λͺ¨λ κ²½μ°μμ μ¬μ©νλ μ΄μ κ° λμ§ λͺ»ν©λλ€.
μΈμ κ° CollectionPipedUpdate.MAX_PIPED_ITEM_COUNT κ°μ΄ 700μΌλ‘ λ³κ²½λ μλ μμ΅λλ€.
μ΄ κ°μ΄ λ³κ²½λλλΌλ, ν
μ€νΈ μ½λλ μ μμ μΌλ‘ λμν΄μΌ ν©λλ€.
λ°λΌμ, μ½λ λ‘μ§μ νμΈνκ³ κ·Έ λ‘μ§μ λ§λ κ°μ μ¬μ©ν΄μΌ ν©λλ€.
μ½λλ₯Ό λͺ¨λ νμΈν΄ 보μκ³ ,
CollectionPipedInsert.MAX_PIPED_ITEM_COUNT κ°μ μ¬μ©νλ κ²μ΄ λ§λ€λΌκ³ νλ©΄,
μΆ©λΆν μ€λͺ
μ΄ λ μ μμ κ²μ
λλ€.
There was a problem hiding this comment.
μ΄ κ°μ΄ λ³κ²½λλλΌλ, ν μ€νΈ μ½λλ μ μμ μΌλ‘ λμν΄μΌ ν©λλ€. λ°λΌμ, μ½λ λ‘μ§μ νμΈνκ³ κ·Έ λ‘μ§μ λ§λ κ°μ μ¬μ©ν΄μΌ ν©λλ€.
pipe max count κ°μ΄ λ³κ²½ μ, κ³ λ €ν μ μλ λ κ°μ§ κ²½μ°μ λλ€.
- μΊμμλ²λ κ°κ³Ό ν¨κ» λ³κ²½ -> ν μ€νΈ μ½λ μ±κ³΅ (λ§μνμ μ μμ μΈ λμμ μν)
- κ°λ§ λ³κ²½ -> ν μ€νΈ μ½λ μ€ν¨λ‘ μΈν λ³κ²½ κ°μ§ κ°λ₯
νμ¬ κ΅¬ν μμ Insert / Update MAX_PIPED_ITEM_COUNTμ μλ©ν±μ μλ€λ©΄
λ κ°μ§ κ°μ λ³κ²½μ ν¨κ» μ΄λ£¨μ΄μ§ κ²μ΄λΌκ³ μμν©λλ€.
μΈμ κ° CollectionPipedUpdate.MAX_PIPED_ITEM_COUNT κ°μ΄
700μΌλ‘ λ³κ²½λλ€λ©΄
CollectionPipedInsert.MAX_PIPED_ITEM_COUNTλ ν¨κ»
700μΌλ‘ λ³κ²½λ κ°λ₯μ±μ΄ λ λμ§ μλμ?
κ²°λ‘ μ μΌλ‘ λ³μμ μλ―Έμ λ΄λΆ λ‘μ§μ μ΄ν΄λ³΄λ Insertμ MAX_PIPED_ITEM_COUNTλ₯Ό μ¬μ©ν΄λ μκ΄ μλ€κ³ μκ°ν©λλ€.
brido4125
force-pushed
the
remove/pipecount
branch
from
03533d7 to
781ca29
Compare
| @@ -145,7 +146,7 @@ void testMaxPipedExist() { | |||
| List<Object> findValues = new ArrayList<>(); | |||
|
|
|||
| // insert items | |||
| for (int i = 0; i < mc.getMaxPipedItemCount(); i++) { | |||
| for (int i = 0; i < CollectionPipedInsert.MAX_PIPED_ITEM_COUNT; i++) { | |||
There was a problem hiding this comment.
λ³κ²½νμ§ μμ μ΄μ λ₯Ό μλ €μ£ΌμΈμ.
| @@ -41,7 +42,7 @@ class MopBulkAPITest extends BaseIntegrationTest { | |||
| private final Map<String, Object> updateMap = new HashMap<>(); | |||
|
|
|||
| private int getValueCount() { | |||
| return mc.getMaxPipedItemCount(); | |||
| return CollectionPipedInsert.MAX_PIPED_ITEM_COUNT; | |||
There was a problem hiding this comment.
μ λ€ λμΌνκ² 500μΌλ‘ μ€μ λμ΄μμ΅λλ€.
μμ μ΄μ κ°
CollectionPipedInsert.MAX_PIPED_ITEM_COUNT κ°μ λͺ¨λ κ²½μ°μμ μ¬μ©νλ μ΄μ κ° λμ§ λͺ»ν©λλ€.
μΈμ κ° CollectionPipedUpdate.MAX_PIPED_ITEM_COUNT κ°μ΄ 700μΌλ‘ λ³κ²½λ μλ μμ΅λλ€.
μ΄ κ°μ΄ λ³κ²½λλλΌλ, ν
μ€νΈ μ½λλ μ μμ μΌλ‘ λμν΄μΌ ν©λλ€.
λ°λΌμ, μ½λ λ‘μ§μ νμΈνκ³ κ·Έ λ‘μ§μ λ§λ κ°μ μ¬μ©ν΄μΌ ν©λλ€.
μ½λλ₯Ό λͺ¨λ νμΈν΄ 보μκ³ ,
CollectionPipedInsert.MAX_PIPED_ITEM_COUNT κ°μ μ¬μ©νλ κ²μ΄ λ§λ€λΌκ³ νλ©΄,
μΆ©λΆν μ€λͺ
μ΄ λ μ μμ κ²μ
λλ€.
brido4125
force-pushed
the
remove/pipecount
branch
from
781ca29 to
8508363
Compare
brido4125
force-pushed
the
remove/pipecount
branch
from
8508363 to
c64fad0
Compare
π Related Issue
https://github.com/jam2in/arcus-works/issues/654#event-15614575064
β¨οΈ What I did
getMaxPipedItemCount λ©μλ μ κ±°