TEST: Add unit tests for MemcachedConnection.handleCacheNodesChange() method in replication mode.
#851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uhm0311
force-pushed
the
uhm0311/repl_test
branch
from
24b54b7 to
ee4f051
Compare
brido4125
previously approved these changes
Dec 11, 2024
uhm0311
force-pushed
the
uhm0311/repl_test
branch
from
ee4f051 to
10d2447
Compare
oliviarla
reviewed
Dec 11, 2024
uhm0311
force-pushed
the
uhm0311/repl_test
branch
from
10d2447 to
932e67d
Compare
oliviarla
previously approved these changes
Dec 11, 2024
jhpark816
reviewed
Dec 11, 2024
src/test/manual/net/spy/memcached/MemcachedConnectionReplTest.java
Outdated
Show resolved
Hide resolved
| assertEquals(2, locator.getAllGroups().size()); | ||
|
|
||
| conn.setCacheNodesChange(ArcusReplNodeAddress.getAddresses( | ||
| "g0^M^127.0.0.4:11211,g0^S^127.0.0.3:11211,g1^M^127.0.0.2:11211,g1^S^127.0.0.1:11211")); |
There was a problem hiding this comment.
์ด๋ ๊ฒ switchover ๋ฐ์ํ๋ ๊ฒฝ์ฐ๊ฐ ์์ผ๋, ์ด๋ฌํ ํ ์คํธ๋ ์์ด๋ ๋์ง ์๋ ์๊ฐํฉ๋๋ค.
There was a problem hiding this comment.
์ผ๋ถ๋ฌ ๋ง๋ ์ผ์ด์ค์ด๋ฏ๋ก ๋ฉ์๋ ์ด๋ฆ์ edge case๋ฅผ ๋ฃ๋ ๊ฒ์ผ๋ก ์คํ๋ผ์ธ ํฉ์ํ์์ต๋๋ค.
โฆ)` method in replication mode.
uhm0311
force-pushed
the
uhm0311/repl_test
branch
from
932e67d to
2d67fa8
Compare
jhpark816
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
๐ Related Issue
โจ๏ธ What I did