INTERNAL: Refactor logic and add comments in addKeyToChunk. #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhpark816
reviewed
Jan 10, 2024
| */ | ||
| private void addKeyToChunk(Map<MemcachedNode, List<Collection<String>>> chunkMap, String key) { | ||
| MemcachedNode node = conn.findNodeByKey(key); | ||
| List<Collection<String>> keyListByNode = chunkMap.get(node); |
There was a problem hiding this comment.
keyListByNode => keyChunkListByNode 이지만 줄여서 keyChunkList 가 어떤지?
brido4125
force-pushed
the
enhance/bulkGet
branch
from
cb27795 to
d83d5f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
asyncGetBulk와 asyncGetsBulk에서 사용되는
addKeyToChunk 메서드의 인자 리팩토링과 주석을 추가하였습니다.
또한 메서드 내의 변수명을 직관적으로 변경하였습니다.