INTERNAL: Add comments to new SMGetResult merge method. #707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uhm0311
force-pushed
the
uhm0311/develop6
branch
2 times, most recently
from
c15a6e9 to
846abc6
Compare
|
@uhm0311
|
|
해당 작업을 수행하기 위해선 코드를 정확히 이해하는 것이 필요한데, 주석이 없으면 코드를 볼 때마다 헷갈릴 것 같습니다. |
jhpark816
reviewed
Dec 26, 2023
| int comp, pos = 0; | ||
| for (SMGetElement<T> result : eachResult) { | ||
| duplicated = false; | ||
| for (; pos < mergedResult.size(); pos++) { | ||
| // compare b+tree key | ||
| // Compare bkey to search proper position of current eachResult in mergedResult. | ||
|
|
||
| comp = result.compareBkeyTo(mergedResult.get(pos)); | ||
| if ((reverse) ? (0 < comp) : (0 > comp)) { |
There was a problem hiding this comment.
여기도 (comp > 0) : (comp < 0) 형태가 낫습니다.
| // Therefore, less cache key is remain in mergedResult. | ||
| // Greater cache key is cache key of mergedResult.get(position). | ||
| // and less cache key is key of current eachResult. | ||
| // EX: key0 vs. key1, remove key1. key0 is remained. |
There was a problem hiding this comment.
여기 주석도 꼭 필요한 것만 두도록 하시죠.
| break; | ||
| } | ||
| if (comp == 0) { // compare key string | ||
| if (comp == 0) { | ||
| // Duplicated bkey. Compare the "cache key". | ||
| int keyComp = result.compareKeyTo(mergedResult.get(pos)); | ||
| if ((reverse) ? (0 < keyComp) : (0 > keyComp)) { |
There was a problem hiding this comment.
(keyComp > 0) : (keyComp < 0) 형태가 낫습니다.
uhm0311
force-pushed
the
uhm0311/develop6
branch
2 times, most recently
from
4ebd529 to
ba1af5c
Compare
|
반영했습니다. |
jhpark816
reviewed
Dec 27, 2023
| } | ||
| break; | ||
| } else { | ||
| if (unique) { | ||
| duplicated = true; | ||
| // Same key and same bkey. do NOT insert. |
There was a problem hiding this comment.
same bkey 이지만, same key는 아닙니다.
unique bkey 조회인 경우,
reverse 여부에 따른 key 정렬 순서에서 가장 앞에 있는 key를 결과에 포함시키고,
나머지 key들은 결과에 포함시키지 않게 됩니다.
same bkey이지만 key는 max key or min key가 아니어서 결과에 insert하지 않는 것입니다.
주석이 아래 의미이어야 할 것 같습니다.
// same bkey but not the first key in the sorting order. do NOT insert.
ba1af5c to
fa1a0e4
Compare
jhpark816
reviewed
Dec 27, 2023
| } | ||
| break; | ||
| } else { | ||
| if (unique) { | ||
| duplicated = true; | ||
| // Same bkey but key is NOT in sorting order. do NOT insert. |
There was a problem hiding this comment.
아래와 같이 변경하시죠.
// NOT the first cache key with the same bkey. do NOT insert.
uhm0311
force-pushed
the
uhm0311/develop6
branch
from
fa1a0e4 to
e0420d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New SMGetResult의 Merge 메소드에 주석을 추가했습니다.