INTERNAL: Change failedOpreationStatus and resultOperationStatus from List<OperationStatus> to CollectionOperationStatus. #705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brido4125
reviewed
Dec 22, 2023
uhm0311
force-pushed
the
uhm0311/develop4
branch
from
f45d872 to
d2adee4
Compare
|
주석 추가했습니다. |
brido4125
approved these changes
Dec 22, 2023
jhpark816
reviewed
Dec 22, 2023
| } | ||
| return new CollectionOperationStatus(resultOperationStatus.get(0)); | ||
| return resultOperationStatus; |
There was a problem hiding this comment.
@uhm0311
질문입니다.
아래 경우에서 getOperationStatus() 호출되는 경우는 없는 거죠?
즉, smget 연산이 merge 작업이 완료되어 failed/result 중의 하나가 설정된 경우만 getOperationStatus() 호출될 수 있는 거죠?
- 기존 방식에서 failed/result OperationStatus가 모두 empty인 경우
- 신규 방식에서 failed/result OperationStatus가 모두 null인 경우
There was a problem hiding this comment.
OperationStatus가 설정된 뒤에 OperationCallback.complete()가 호출되어 Future.get()의 블로킹이 해제되므로 그럴 일은 없을 것 같습니다.
jhpark816
reviewed
Dec 26, 2023
| @@ -109,6 +112,10 @@ public void mergeSMGetElements(final List<SMGetElement<T>> eachResult, | |||
|
|
|||
| @Override | |||
| public void makeResultOperationStatus() { | |||
| if (resultOperationStatus != null) { | |||
| return; | |||
| } | |||
There was a problem hiding this comment.
위와 같이 null 아닌 경우는 리턴하는 코드를 넣을 필요가 있나요?
| @@ -2108,7 +2108,9 @@ public void receivedStatus(OperationStatus status) { | |||
| } | |||
| } else { | |||
| stopCollect.set(true); | |||
| result.addFailedOperationStatus(status); | |||
|
|
|||
| // Multi key operation but SMGetFuture returns only one, the first failedOperationStatus. | |||
There was a problem hiding this comment.
위 의견에 따라 추가한 주석인데, 그래도 제거할까요?
There was a problem hiding this comment.
예 제거하시죠.
다른 곳의 OperationStatus 처리도 변경될 것으로 예상됩니다.
uhm0311
force-pushed
the
uhm0311/develop4
branch
from
d2adee4 to
ede98bc
Compare
… List<OperationStatus> to CollectionOperationStatus.
uhm0311
force-pushed
the
uhm0311/develop4
branch
from
ede98bc to
6a3475f
Compare
|
모두 반영했습니다. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/jam2in/arcus-works/issues/482
위 이슈 일부를 반영했습니다.