TEST: Fix test failure due to unsupported reflection operation on JDK 12+ #692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brido4125
reviewed
Nov 30, 2023
| @@ -43,10 +42,6 @@ private Queue<Operation> getQueue(String queueFieldName, TCPMemcachedNodeImpl no | |||
| Field queueField = TCPMemcachedNodeImpl.class.getDeclaredField(queueFieldName); | |||
| queueField.setAccessible(true); | |||
|
|
|||
| Field modifiersField = Field.class.getDeclaredField("modifiers"); | |||
| modifiersField.setAccessible(true); | |||
| modifiersField.setInt(queueField, queueField.getModifiers() & ~Modifier.FINAL); | |||
There was a problem hiding this comment.
우선 궁금한 점은 아래와 같습니다.
- Field라는 클래스의 field로 존재하는
modifiers는 final 키워드가 붙어 있지 않아서setAccessible을 호출하는게 의미가 없지 않나요? - setInt() 메서드를 호출하는 의미가 무엇인지 설명 부탁드립니다.
There was a problem hiding this comment.
Field.class.getDeclaredField("modifiers")는 필드의 Modifier를 가져오는 것입니다.
private final String a; 라는 필드가 있다면, int 값으로 priavte에 해당하는 플래그와 final에 해당하는 플래그가 bit or 연산자로 합쳐져 반환됩니다.
Field.setAccessible(true);는 private으로 선언된 필드를 public으로 전환하여 자유롭게 접근하겠다는 의미입니다.
modifiersField.setInt()는 int 플래그를 재설정하는 것으로, 위 코드에서는 기존 Modifier에서 final에 해당하는 플래그를 제거하는 것입니다.
|
commit 메세지로 어떤 것에 의한 실패를 수정한 것인지 구체적으로 나타낼 수 있나요? |
uhm0311
force-pushed
the
uhm0311/develop4
branch
from
087a491 to
d22cf31
Compare
uhm0311
changed the title
|
커밋 메세지 수정했습니다. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/jam2in/arcus-works/issues/470
위 이슈를 해결하는 PR 입니다.