DOCS: Fix return value in asyncSopPipedExistBulk api. #687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uhm0311
approved these changes
Oct 25, 2023
jhpark816
reviewed
Dec 18, 2023
| null | CollectionResponse.UNREADABLE | 해당 key를 읽을 수 없는 상태임. (unreadable item상태) | ||
| empty map | CollectionResponse.NOT_FOUND | Key miss (주어진 key에 해당하는 item이 없음) | ||
| empty map | CollectionResponse.TYPE_MISMATCH | 해당 key가 set이 아님 | ||
| empty map | CollectionResponse.UNREADABLE | 해당 key를 읽을 수 없는 상태임. (unreadable item상태) |
There was a problem hiding this comment.
emtpy map 이라 지칭하는 것은 괜찮은 것 같음.
반면,
- not null 이라 지칭하는 것은 어색함
- noe null일 때 getOperationStatus() 값도 확인 필요.
There was a problem hiding this comment.
not null 이라 지칭하는 것은 어색함
filled map 또한 가능할것 같습니다.
noe null일 때 getOperationStatus() 값도 확인 필요.
-
empty map인 경우 : gotStatus 메서드 인자로 받은 OperationStatus 설정
-
filled map 인 경우 : receivedStatus의 인자로 받은 OperationStatus로 설정
- EXIST : CollecitonOperation.END
- NOT_EXIST : CollecitonOperation.END
There was a problem hiding this comment.
- 설명 부분이 다음과 같이 수정되어야 할 것 같음
- "주어진 값들에 대한 존재유무 확인 완료"
- 따라서, 성공한 경우는 1개 row만으로 표현
brido4125
force-pushed
the
docs/fixSopExistsBulk
branch
from
7063ea1 to
0386864
Compare
uhm0311
approved these changes
Dec 19, 2023
jhpark816
reviewed
Dec 19, 2023
| null | CollectionResponse.UNREADABLE | 해당 key를 읽을 수 없는 상태임. (unreadable item상태) | ||
| empty map | CollectionResponse.NOT_FOUND | Key miss (주어진 key에 해당하는 item이 없음) | ||
| empty map | CollectionResponse.TYPE_MISMATCH | 해당 key가 set이 아님 | ||
| empty map | CollectionResponse.UNREADABLE | 해당 key를 읽을 수 없는 상태임. (unreadable item상태) |
There was a problem hiding this comment.
- 설명 부분이 다음과 같이 수정되어야 할 것 같음
- "주어진 값들에 대한 존재유무 확인 완료"
- 따라서, 성공한 경우는 1개 row만으로 표현
brido4125
force-pushed
the
docs/fixSopExistsBulk
branch
from
0386864 to
666e946
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
현재 문서를 구현에 맞춘 형태로 변경하였습니다.
https://github.com/jam2in/arcus-works/issues/455