FIX: Allow user to access canceled reason of CollectionBulkInsertOperation. #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brido4125 리뷰 바랍니다. |
brido4125
reviewed
Jun 29, 2023
src/main/java/net/spy/memcached/protocol/ascii/CollectionInsertOperationImpl.java
Show resolved
Hide resolved
brido4125
approved these changes
Jun 29, 2023
jhpark816
reviewed
Jun 29, 2023
| @@ -144,6 +145,7 @@ public void initialize() { | |||
|
|
|||
| @Override | |||
| protected void wasCancelled() { | |||
| ((CollectionBulkInsertOperation.Callback) getCallback()).gotStatus(key, STORE_CANCELED); | |||
There was a problem hiding this comment.
CollectionInsertOperationImpl 클래스가 아니라 CollectionBulkInsertOperation 구현체의 wasCancelled() 메소드를 수정해야 할 것 같습니다.
이러한 수정이 unit test에서 드러나게 할 방법이 있나요?
There was a problem hiding this comment.
다시 보니, 설계부터 잘못된 것 같습니다.
Close 하고 다른 PR로 올리도록 하겠습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#528
위 이슈 PR입니다.