ENHANCE: Change creating callback objects multiple times in pipe oper…

…ation.
naver · Mar 19, 2024 · 1ef9240 · 1ef9240
1 parent 1fcd2d7
commit 1ef9240
Showing 1 changed file with 66 additions and 64 deletions.
diff --git a/src/main/java/net/spy/memcached/ArcusClient.java b/src/main/java/net/spy/memcached/ArcusClient.java
@@ -849,41 +849,42 @@ <T> CollectionFuture<Map<Integer, CollectionOperationStatus>> asyncCollectionPip
     final PipedCollectionFuture<Integer, CollectionOperationStatus> rv =
             new PipedCollectionFuture<Integer, CollectionOperationStatus>(latch, operationTimeout);
 
-    for (int i = 0; i < updateList.size(); i++) {
-      final CollectionPipedUpdate<T> update = updateList.get(i);
-      final int idx = i;
-
-      Operation op = opFact.collectionPipedUpdate(key, update,
-          new CollectionPipedUpdateOperation.Callback() {
-            // each result status
-            public void receivedStatus(OperationStatus status) {
-              CollectionOperationStatus cstatus;
-
-              if (status instanceof CollectionOperationStatus) {
-                cstatus = (CollectionOperationStatus) status;
-              } else {
-                getLogger().warn("Unhandled state: " + status);
-                cstatus = new CollectionOperationStatus(status);
-              }
-              rv.setOperationStatus(cstatus);
-            }
+    CollectionPipedUpdateOperation.Callback callback = new CollectionPipedUpdateOperation.Callback() {
+      private int opIdx = 0;
 
-            // complete
-            public void complete() {
-              latch.countDown();
-            }
+      @Override
+      public void receivedStatus(OperationStatus status) {
+        opIdx += 1;
+        CollectionOperationStatus cstatus;
 
-            // got status
-            public void gotStatus(Integer index, OperationStatus status) {
-              if (status instanceof CollectionOperationStatus) {
-                rv.addEachResult(index + (idx * CollectionPipedUpdate.MAX_PIPED_ITEM_COUNT),
-                                (CollectionOperationStatus) status);
-              } else {
-                rv.addEachResult(index + (idx * CollectionPipedUpdate.MAX_PIPED_ITEM_COUNT),
-                                new CollectionOperationStatus(status));
-              }
-            }
-          });
+        if (status instanceof CollectionOperationStatus) {
+          cstatus = (CollectionOperationStatus) status;
+        } else {
+          getLogger().warn("Unhandled state: " + status);
+          cstatus = new CollectionOperationStatus(status);
+        }
+        rv.setOperationStatus(cstatus);
+      }
+
+      @Override
+      public void complete() {
+        latch.countDown();
+      }
+
+      @Override
+      public void gotStatus(Integer index, OperationStatus status) {
+        if (status instanceof CollectionOperationStatus) {
+          rv.addEachResult(index + (opIdx * CollectionPipedUpdate.MAX_PIPED_ITEM_COUNT),
+                  (CollectionOperationStatus) status);
+        } else {
+          rv.addEachResult(index + (opIdx * CollectionPipedUpdate.MAX_PIPED_ITEM_COUNT),
+                  new CollectionOperationStatus(status));
+        }
+      }
+    };
+
+    for (CollectionPipedUpdate<T> pipedUpdate : updateList) {
+      Operation op = opFact.collectionPipedUpdate(key, pipedUpdate, callback);
       rv.addOperation(op);
       addOp(key, op);
     }
@@ -3291,41 +3292,42 @@ <T> CollectionFuture<Map<Integer, CollectionOperationStatus>> asyncCollectionPip
     final PipedCollectionFuture<Integer, CollectionOperationStatus> rv =
             new PipedCollectionFuture<Integer, CollectionOperationStatus>(latch, operationTimeout);
 
-    for (int i = 0; i < insertList.size(); i++) {
-      final CollectionPipedInsert<T> insert = insertList.get(i);
-      final int idx = i;
+    CollectionPipedInsertOperation.Callback callback = new CollectionPipedInsertOperation.Callback() {
+      private int opIdx = 0;
 
-      Operation op = opFact.collectionPipedInsert(key, insert,
-          new CollectionPipedInsertOperation.Callback() {
-            // each result status
-            public void receivedStatus(OperationStatus status) {
-              CollectionOperationStatus cstatus;
+      @Override
+      public void receivedStatus(OperationStatus status) {
+        opIdx += 1;
+        CollectionOperationStatus cstatus;
 
-              if (status instanceof CollectionOperationStatus) {
-                cstatus = (CollectionOperationStatus) status;
-              } else {
-                getLogger().warn("Unhandled state: " + status);
-                cstatus = new CollectionOperationStatus(status);
-              }
-              rv.setOperationStatus(cstatus);
-            }
+        if (status instanceof CollectionOperationStatus) {
+          cstatus = (CollectionOperationStatus) status;
+        } else {
+          getLogger().warn("Unhandled state: " + status);
+          cstatus = new CollectionOperationStatus(status);
+        }
+        rv.setOperationStatus(cstatus);
+      }
 
-            // complete
-            public void complete() {
-              latch.countDown();
-            }
+      @Override
+      public void complete() {
+        latch.countDown();
+      }
 
-            // got status
-            public void gotStatus(Integer index, OperationStatus status) {
-              if (status instanceof CollectionOperationStatus) {
-                rv.addEachResult(index + (idx * CollectionPipedInsert.MAX_PIPED_ITEM_COUNT),
-                                (CollectionOperationStatus) status);
-              } else {
-                rv.addEachResult(index + (idx * CollectionPipedInsert.MAX_PIPED_ITEM_COUNT),
-                                new CollectionOperationStatus(status));
-              }
-            }
-          });
+      @Override
+      public void gotStatus(Integer index, OperationStatus status) {
+        if (status instanceof CollectionOperationStatus) {
+          rv.addEachResult(index + (opIdx * CollectionPipedInsert.MAX_PIPED_ITEM_COUNT),
+                  (CollectionOperationStatus) status);
+        } else {
+          rv.addEachResult(index + (opIdx * CollectionPipedInsert.MAX_PIPED_ITEM_COUNT),
+                  new CollectionOperationStatus(status));
+        }
+      }
+    };
+
+    for (CollectionPipedInsert<T> pipedInsert : insertList) {
+      Operation op = opFact.collectionPipedInsert(key, pipedInsert, callback);
       rv.addOperation(op);
       addOp(key, op);
     }