Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Tables from fields __all__ check #83

Merged
merged 3 commits into from
Mar 29, 2024
Merged

Conversation

snaselj
Copy link
Contributor

@snaselj snaselj commented Mar 22, 2024

Closes NaN

What's Changed

  • Removed Tables from being checked to use __all__.
  • Added tests for all classes and fixed the checker.

@snaselj snaselj self-assigned this Mar 22, 2024
@snaselj snaselj marked this pull request as ready for review March 26, 2024 06:47
@snaselj snaselj requested review from cmsirbu, Kircheneer and a team as code owners March 26, 2024 06:47
@glennmatthews
Copy link
Contributor

Is this blocked on anything?

@snaselj
Copy link
Contributor Author

snaselj commented Mar 29, 2024

Is this blocked on anything?

Only the review and approval @glennmatthews :-)

Copy link
Collaborator

@cmsirbu cmsirbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cmsirbu cmsirbu merged commit 27355d1 into develop Mar 29, 2024
15 checks passed
@cmsirbu cmsirbu deleted the u/snaselj-fix-all branch March 29, 2024 10:49
@cmsirbu cmsirbu mentioned this pull request Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants