Update version of dependency pylint #35
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newer version of pylint have deprecated the __implements__ class attribute, but removing that causes earlier versions of pylint to miss checkers. https://github.com/pylint-dev/pylint/blob/f815e9f5fcdd5caffc04e335fc4590a65989ef21/doc/whatsnew/2/2.14/full.rst#L196
cmsirbu
reviewed
Jul 7, 2023
Comment on lines
+9
to
+10
| python = "^3.7.2" | ||
| pylint = "^2.17" |
There was a problem hiding this comment.
I was temped to do the same from the get go, but it will clash when adding into other projects that use ^3.7, which is all plugins baked from our cookie. I think we need to stick to the old one until we bump minimum python to the next minor.
There was a problem hiding this comment.
what would you like me to do with this PR then?
There was a problem hiding this comment.
Hold for a bit. Maybe we can raise the floor at least for 2.0 onwards. There's a sizeable delta in pylint release that all of our projects can't use because of this 3.7.
There was a problem hiding this comment.
Might be able to do poetry add pylint^2.17 --python ^3.7.2 here, we did something similar in core
Kircheneer
added
the
status: blocked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer version of pylint have deprecated the implements class attribute, but removing that causes earlier versions of pylint to miss checkers. https://github.com/pylint-dev/pylint/blob/f815e9f5fcdd5caffc04e335fc4590a65989ef21/doc/whatsnew/2/2.14/full.rst#L196