Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace pydocstyle with ruff #62

Merged
merged 2 commits into from
Jan 9, 2024
Merged

Replace pydocstyle with ruff #62

merged 2 commits into from
Jan 9, 2024

Conversation

snaselj
Copy link
Contributor

@snaselj snaselj commented Jan 8, 2024

Closes: NaN

What's Changed

  • Replaced pydocstyle with ruff in templates.
  • Removed pydocstyle and ruff from root as not necessary.

@snaselj snaselj requested a review from whitej6 January 8, 2024 10:33
@snaselj
Copy link
Contributor Author

snaselj commented Jan 8, 2024

Ready for the review @cmsirbu @whitej6

Copy link
Contributor

@whitej6 whitej6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only thing to check is why GitHub is highlighting some pieces of the pyproject.toml in red. I suspect it's due to it being a templated file but can you verify everything is good?

"D3", # pydocstyle
"D4", # pydocstyle
]
ignore = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea why GitHub is highlighting this in red?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ken identified that this appears to be a GitHub bug - it doesn't like the comment after the last item in the previous list, though as far as I can tell it's perfectly valid TOML.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I've noticed GitHub's diffs combined with syntax highlighting sometimes becomes wonky in Markdown as well.

@itdependsnetworks
Copy link
Contributor

itdependsnetworks commented Jan 8, 2024

Why isn't this coming from drift manager?

I thought I was still looking at firewall models

@whitej6 whitej6 merged commit 148e6d1 into develop Jan 9, 2024
1 check passed
@whitej6 whitej6 deleted the u/snaselj-napps-137-ruff branch January 9, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants