-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace pydocstyle with ruff #62
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only thing to check is why GitHub is highlighting some pieces of the pyproject.toml in red. I suspect it's due to it being a templated file but can you verify everything is good?
"D3", # pydocstyle | ||
"D4", # pydocstyle | ||
] | ||
ignore = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any idea why GitHub is highlighting this in red?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ken identified that this appears to be a GitHub bug - it doesn't like the comment after the last item in the previous list, though as far as I can tell it's perfectly valid TOML.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I've noticed GitHub's diffs combined with syntax highlighting sometimes becomes wonky in Markdown as well.
I thought I was still looking at firewall models |
Closes: NaN
What's Changed
pydocstyle
withruff
in templates.pydocstyle
andruff
from root as not necessary.