Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update for Nautobot v2 #47

Merged
merged 17 commits into from
Dec 5, 2023
Merged

Update for Nautobot v2 #47

merged 17 commits into from
Dec 5, 2023

Conversation

whitej6
Copy link
Contributor

@whitej6 whitej6 commented Nov 8, 2023

No description provided.

glennmatthews
glennmatthews reviewed Nov 8, 2023
View reviewed changes
Copy link
Contributor

@glennmatthews glennmatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a lot of steps in the right direction!

...plates/{{cookiecutter.plugin_name}}/{{cookiecutter.model_class_name | lower }}_retrieve.html Outdated Show resolved Hide resolved
nautobot-app/{{ cookiecutter.project_slug }}/{{cookiecutter.plugin_name}}/navigation.py Outdated Show resolved Hide resolved
nautobot-app/{{ cookiecutter.project_slug }}/{{cookiecutter.plugin_name}}/views.py Outdated Show resolved Hide resolved
jathanism
jathanism reviewed Nov 8, 2023
View reviewed changes
Copy link

@jathanism jathanism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Just two docstrings that need to be updated.

nautobot-app-ssot/{{ cookiecutter.project_slug }}/{{cookiecutter.plugin_name}}/views.py Outdated Show resolved Hide resolved
nautobot-app/{{ cookiecutter.project_slug }}/{{cookiecutter.plugin_name}}/views.py Outdated Show resolved Hide resolved
@whitej6 whitej6 changed the title initial pass on v2 conversion Update for Nautobot v2 Dec 4, 2023
@whitej6 whitej6 requested a review from cmsirbu December 4, 2023 21:59
snaselj
snaselj approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@snaselj snaselj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Left few suggestions to consider.

nautobot-app-ssot/cookiecutter.json Outdated Show resolved Hide resolved
nautobot-app/{{ cookiecutter.project_slug }}/{{ cookiecutter.plugin_name }}/__init__.py Outdated Show resolved Hide resolved
@whitej6
Copy link
Contributor Author

whitej6 commented Dec 5, 2023

Closes: #32

cmsirbu
cmsirbu approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@cmsirbu cmsirbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just one minor nit.

nautobot-app/{{ cookiecutter.project_slug }}/docs/admin/compatibility_matrix.md Outdated Show resolved Hide resolved
@whitej6 whitej6 merged commit 2a1f999 into develop Dec 5, 2023
1 check passed
@whitej6 whitej6 deleted the u/whitej6-v2-updates branch December 5, 2023 19:10
@whitej6 whitej6 mentioned this pull request Dec 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glennmatthews glennmatthews glennmatthews left review comments

@jathanism jathanism jathanism left review comments

@jvanderaa jvanderaa jvanderaa approved these changes

@cmsirbu cmsirbu cmsirbu approved these changes

@snaselj snaselj snaselj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@whitej6 @jathanism @snaselj @glennmatthews @cmsirbu @jvanderaa