Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add python 3.12 support and fix development dependencies in dockerfile #152

Merged
merged 1 commit into from
Aug 26, 2024
Merged

add python 3.12 support and fix development dependencies in dockerfile #152

merged 1 commit into from
Aug 26, 2024

Conversation

gsnider2195
Copy link
Contributor

@gsnider2195 gsnider2195 commented Aug 23, 2024 •
edited
Loading

Closes #129 Closes #148

Changes tested in nautobot/nautobot-app-dev-example#36

@gsnider2195 gsnider2195 requested review from cmsirbu and smk4664 August 23, 2024 17:41
@gsnider2195 gsnider2195 self-assigned this Aug 23, 2024
smk4664
smk4664 approved these changes Aug 23, 2024
View reviewed changes
Copy link
Contributor

@smk4664 smk4664 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I just wanted to call out that we should give a reason for hard-coding the Nautobot Version.

@gsnider2195 gsnider2195 merged commit a32890e into develop Aug 26, 2024
2 checks passed
@gsnider2195 gsnider2195 deleted the u/gas-python-3.12 branch August 26, 2024 16:02
@gsnider2195 gsnider2195 mentioned this pull request Sep 16, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smk4664 smk4664 smk4664 approved these changes

@cmsirbu cmsirbu Awaiting requested review from cmsirbu

Assignees

@gsnider2195 gsnider2195

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@gsnider2195 @smk4664