Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow updating KV bucket settings from add command #1221

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kroepke
Copy link

@kroepke kroepke commented Dec 31, 2024

add --[no]-update flag to add KV command

if set, the update flag will use CreateOrUpdateKeyValue instead of CreateKeyValue to allow changing settings of the bucket

Not passing the parameter retains the original behavior

if set, the update flag will use CreateOrUpdateKeyValue instead of CreateKeyValue to allow changing settings of the bucket

not passing the parameter retains the original behavior
@ripienaar
Copy link
Collaborator

Thanks for this, I think I'd rather model this around how nats stream works with a add and edit commands separate and edit only showing flags that's changeable

@kroepke
Copy link
Author

kroepke commented Jan 9, 2025

Sure, I am happy to update this if you feel it's worth it. I just did it because I ran into wanting to update settings while testing.

@ripienaar
Copy link
Collaborator

Supporting updates to bucket config has been on my todo list but never got to it, so would be very grateful to see a contribution there!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants