-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial Object Store implementation #150
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
9897418
Initial Object Store implementation
mtmk d6b89ca
Run Object store tests in GH CI
mtmk ff8524f
Merge branch 'main' into obj-store-initial-impl
mtmk 63b7dd2
Pull consumer abstraction
mtmk ead74ed
Push consumer channel explanation
mtmk 79df9a8
Object get and delete
mtmk 29ac88a
Merge branch 'main' into obj-store-initial-impl
mtmk 2ed63d9
Stream leave open option
mtmk 318ba50
Stream leave open option
mtmk 9001738
Rename OB to Obj
mtmk 2393fb3
Update NATS.Client.sln.DotSettings
mtmk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| <Project Sdk="Microsoft.NET.Sdk"> | ||
|
|
||
| <PropertyGroup> | ||
| <OutputType>Exe</OutputType> | ||
| <TargetFramework>net6.0</TargetFramework> | ||
| <ImplicitUsings>enable</ImplicitUsings> | ||
| <Nullable>enable</Nullable> | ||
| <IsPackable>false</IsPackable> | ||
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <ProjectReference Include="..\..\src\NATS.Client.ObjectStore\NATS.Client.ObjectStore.csproj" /> | ||
| </ItemGroup> | ||
|
|
||
| </Project> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| using System.Text; | ||
| using NATS.Client.Core; | ||
| using NATS.Client.JetStream; | ||
| using NATS.Client.ObjectStore; | ||
| using NATS.Client.ObjectStore.Models; | ||
|
|
||
| var nats = new NatsConnection(); | ||
| var js = new NatsJSContext(nats); | ||
| var ob = new NatsObjContext(js); | ||
|
|
||
| var store = await ob.CreateObjectStore(new NatsObjConfig("o1")); | ||
|
|
||
| var meta = new ObjectMetadata { Name = "k1", Options = new Options { MaxChunkSize = 10 }, }; | ||
|
|
||
| var stringBuilder = new StringBuilder(); | ||
| for (var i = 0; i < 9; i++) | ||
| { | ||
| stringBuilder.Append($"{i:D2}-4567890"); | ||
| } | ||
|
|
||
| var buffer90 = stringBuilder.ToString(); | ||
| { | ||
| var buffer = Encoding.ASCII.GetBytes(buffer90); | ||
| var stream = new MemoryStream(buffer); | ||
|
|
||
| await store.PutAsync(meta, stream); | ||
|
|
||
| var data = await store.GetInfoAsync("k1"); | ||
|
|
||
| Console.WriteLine($"DATA: {data}"); | ||
| } | ||
|
|
||
| { | ||
| var memoryStream = new MemoryStream(); | ||
| await store.GetAsync("k1", memoryStream); | ||
| await memoryStream.FlushAsync(); | ||
| var buffer = memoryStream.ToArray(); | ||
| Console.WriteLine($"buffer:{Encoding.ASCII.GetString(buffer)}"); | ||
| } | ||
|
|
||
| Console.WriteLine("Bye"); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity, what is the benefit of using this over
MemoryPool<byte>.Shared?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MemoryPool.Shared.Rent returns at least the size asked for, which usually rounds up to some 2^n. This wrapper chops the memory to exact size so when it's passed to stream read/write or down the line to publish or something you won't need to pass the actual size.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btw, we are still renting it from MemoryPool.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I see that now. Clever!