Updated interface to include Async events.

nats-io · Jan 24, 2024 · 0efed45 · 0efed45
1 parent 6b22255
commit 0efed45
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/src/NATS.Client.Core/INatsConnection.cs b/src/NATS.Client.Core/INatsConnection.cs
@@ -2,6 +2,14 @@ namespace NATS.Client.Core;
 
 public interface INatsConnection : IAsyncDisposable
 {
+    event AsyncEventHandler<NatsEventArgs>? ConnectionDisconnected;
+
+    event AsyncEventHandler<NatsEventArgs>? ConnectionOpened;
+
+    event AsyncEventHandler<NatsEventArgs>? ReconnectFailed;
+
+    event AsyncEventHandler<NatsMessageDroppedEventArgs>? MessageDropped;
+
     INatsServerInfo? ServerInfo { get; }
 
     NatsOpts Opts { get; }

diff --git a/tests/NATS.Client.Core.Tests/NatsConnectionTest.cs b/tests/NATS.Client.Core.Tests/NatsConnectionTest.cs
@@ -380,10 +380,6 @@ public void InterfaceShouldHaveSamePublicPropertiesEventsAndMethodAsClass()
         {
             var name = classInfo.Name;
 
-            // TODO: enable this check when we have events pulled up to the interface
-            if (Regex.IsMatch(name, @"add_|remove_"))
-                continue;
-
             interfaceMethods.Select(m => m.Name).Should().Contain(name);
         }
     }