Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize Repo / Solution with nats.net #26

Merged
merged 8 commits into from
Dec 9, 2024
Merged

Standardize Repo / Solution with nats.net #26

merged 8 commits into from
Dec 9, 2024

Conversation

rickdotnet
Copy link
Collaborator

@rickdotnet rickdotnet commented Dec 5, 2024

Addresses #25 .

There's a small deviation from nats.net. The .sln and solution artifacts are in the src folder, instead of the repo root, as they are in nats.net.

@mtmk can you take a look at the ci/cd bits?

@rickdotnet rickdotnet requested a review from mtmk December 5, 2024 22:01
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.88%. Comparing base (d6934d7) to head (877bec9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
+ Coverage   73.69%   76.88%   +3.18%     
==========================================
  Files          48       48              
  Lines         844      809      -35     
  Branches       63       63              
==========================================
  Hits          622      622              
+ Misses        197      162      -35     
  Partials       25       25              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtmk
Copy link
Collaborator

mtmk commented Dec 6, 2024

@rickdotnet ci/cd looks good and is passing anyway. release workflow looks good and should be fine but we'll have to fix any issues it there are at the time of release.

@rickdotnet rickdotnet marked this pull request as ready for review December 7, 2024 16:26
@rickdotnet
Copy link
Collaborator Author

rickdotnet commented Dec 7, 2024

Not sure if these were there for a reason, but they don't appear to be used. And, since we are moving things around anyways.. figured we could them into the preview that follows the this PR.

@mtmk
Copy link
Collaborator

mtmk commented Dec 9, 2024

Not sure if these were there for a reason, but they don't appear to be used. And, since we are moving things around anyways.. figured we could them into the preview that follows the this PR.

those are copy paste errors from nats.net project. yea looks like we don't need them.

Copy link
Collaborator

@mtmk mtmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mtmk mtmk merged commit 885aa5b into main Dec 9, 2024
8 checks passed
@mtmk mtmk deleted the rick/25-repo-reorg branch December 9, 2024 21:24
@mtmk mtmk mentioned this pull request Dec 11, 2024
mtmk added a commit that referenced this pull request Dec 11, 2024
* Standardize Repo / Solution with nats.net (#26)
* Also fixes version.txt location and adds test timeout.

PS Not sure if 9/10 will compare properly. I should've zero padded
before i suppose. we'll see.
@rickdotnet rickdotnet linked an issue Dec 11, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standardize folder structure
2 participants