-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize Repo / Solution with nats.net #26
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #26 +/- ##
==========================================
+ Coverage 73.69% 76.88% +3.18%
==========================================
Files 48 48
Lines 844 809 -35
Branches 63 63
==========================================
Hits 622 622
+ Misses 197 162 -35
Partials 25 25 ☔ View full report in Codecov by Sentry. |
11e9722
to
1b022e2
Compare
@rickdotnet ci/cd looks good and is passing anyway. release workflow looks good and should be fine but we'll have to fix any issues it there are at the time of release. |
Not sure if these were there for a reason, but they don't appear to be used. And, since we are moving things around anyways.. figured we could them into the preview that follows the this PR. |
those are copy paste errors from nats.net project. yea looks like we don't need them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Standardize Repo / Solution with nats.net (#26) * Also fixes version.txt location and adds test timeout. PS Not sure if 9/10 will compare properly. I should've zero padded before i suppose. we'll see.
Addresses #25 .
There's a small deviation from nats.net. The
.sln
and solution artifacts are in thesrc
folder, instead of the repo root, as they are innats.net
.@mtmk can you take a look at the ci/cd bits?