-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate travis tests to Github Actions #139
Conversation
…b-base`, since this project does not use react
I'm not sure why the actions aren't running here; @nathanhleung, you may need to check a box in the repo settings to allow all actions to run? |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ok, fixed the action, so now it should work without changes :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ljharb!!
@nathanhleung before merging this, did you enable actions to run on this repo? the actions never actually ran on this PR. |
These are the actions settings I'm seeing for the repo, not sure if there's anything else I needed to enable? In any case, I see that they've run on my end also.
I think I remember reading something about this somewhere, so this sounds right. Thank you to both of you for coordinating this effort! |
hmm, actions from forks usually run for me, but maybe that’s it. Thanks for checking :-) |
See #127
2 pnpm tests are failing, but pass for me locally, so I'm not sure how to best debug this.