Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate travis tests to Github Actions #139

Merged
merged 2 commits into from
Apr 6, 2021

Conversation

ljharb
Copy link
Collaborator

@ljharb ljharb commented Apr 2, 2021

See #127

2 pnpm tests are failing, but pass for me locally, so I'm not sure how to best debug this.

@ljharb ljharb marked this pull request as ready for review April 2, 2021 16:27
@ljharb ljharb marked this pull request as draft April 2, 2021 16:28
@ljharb
Copy link
Collaborator Author

ljharb commented Apr 2, 2021

I'm not sure why the actions aren't running here; @nathanhleung, you may need to check a box in the repo settings to allow all actions to run?

@karlhorky

This comment has been minimized.

@karlhorky

This comment has been minimized.

@karlhorky

This comment has been minimized.

@karlhorky

This comment has been minimized.

@karlhorky

This comment has been minimized.

@ljharb

This comment has been minimized.

@ljharb

This comment has been minimized.

@ljharb

This comment has been minimized.

@ljharb
Copy link
Collaborator Author

ljharb commented Apr 3, 2021

ok, fixed the action, so now it should work without changes :-)

@ljharb ljharb marked this pull request as ready for review April 3, 2021 20:34
@ljharb ljharb requested a review from nathanhleung April 3, 2021 20:34
Copy link
Owner

@nathanhleung nathanhleung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ljharb!!

@nathanhleung nathanhleung merged commit 41c214a into nathanhleung:master Apr 6, 2021
@ljharb
Copy link
Collaborator Author

ljharb commented Apr 6, 2021

@nathanhleung before merging this, did you enable actions to run on this repo? the actions never actually ran on this PR.

@ljharb ljharb deleted the travis branch April 6, 2021 05:08
@karlhorky
Copy link

karlhorky commented Apr 6, 2021

Seems like they're running now (at least on master):

Screen Shot 2021-04-06 at 10 21 39

Maybe the reason they didn't run in this PR has something to do with the restrictions that GitHub Actions have on running actions from forks?

@nathanhleung
Copy link
Owner

@nathanhleung before merging this, did you enable actions to run on this repo? the actions never actually ran on this PR.

Screen Shot 2021-04-06 at 10 24 33 AM

These are the actions settings I'm seeing for the repo, not sure if there's anything else I needed to enable? In any case, I see that they've run on my end also.

Maybe the reason they didn't run in this PR has something to do with the restrictions that GitHub Actions have on running actions from forks?

I think I remember reading something about this somewhere, so this sounds right.

Thank you to both of you for coordinating this effort!

@ljharb
Copy link
Collaborator Author

ljharb commented Apr 6, 2021

hmm, actions from forks usually run for me, but maybe that’s it. Thanks for checking :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants