Webhook improvements #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This commit adds some support to get the actual webhook url and other details. The webhook url is required as a parameter when deleting the webhook. When deleting the webhook, the configured webhook may be unknown. In such cases it is necessary to have a means to actually retrieve the url in order to provide the parameter required for a succssful delete request.
- Changed from DEL to POST so that it works and matches the API spec
- Updated the test expectation to match the api spec
nasa9084
approved these changes
Mar 27, 2024
There was a problem hiding this comment.
@wcwynn Thank you for your contribution!
Honestly, I personally don't use the webhook feature so I cannot confirm if the implementation is correct.
so let me merge this PR now and release it in a new version and then please make another PR if you found any issues when you use this feature 🙇
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added ability to receive actual webhook details and fixed a bug with deletion
details. The webhook url is required as a parameter when deleting the
webhook. When deleting the webhook, the configured webhook may be
unknown to the application program. In such cases it is necessary to have
a means to actually retrieve the url in order to provide the parameter required
for a successful delete request. Similarly, when checking if the configured webhook
is enabled, its necessary to actually examine the response to determine the flag
value that was returned by the api.