Make ROS backend generate Dockerfile. Refs #136. #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves the files generated by Ogma into a subdirectory, to make it easier to place them conforming to the expected structure in a ROS application inside a docker image.
Adjust README to match new locations of files generated by the `ros` command.
Ogma doesn't currently generate a Dockerfile with the ROS packages. That makes it harder for users to know how to use the produce of Ogma. This commit adds a Dockerfile to the ROS template used by Ogma, and to the list of files installed with Ogma. The dockerfile simply compiles the monitoring application inside Space ROS.
A prior commit has modified the `ros` command to generate an additional Dockerfile. This commit adjusts the documentation in the README to let users know what the Dockerfile is for and how to build the image.
This commit adds a CI Job that checks that Ogma can generate a ROS monitoring package, and the package compiles correctly using the dockerfile generated with the ROS package.
|
Change Manager: Verified that:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make ROS backend generate dockerfile that compiles the generated monitoring node, and add a test to check that the generated dockerfile works, as prescribed in the solution proposed for #136.