Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAS-2280: Merge TRANSPARENT_IDX and NODATA_IDX to increase available … #41

Merged
merged 4 commits into from
Dec 20, 2024

Conversation

flamingbear
Copy link
Member

@flamingbear flamingbear commented Dec 19, 2024

Description

Merges two similar indices into one.

TRANSPARENT_IDX is removed and NODATA_IDX is used instead.
TRANSPARENT_RGBA is replaced with NODATA_RGBA which has the same value.
The number of available colors is increased from 254 to 255 (indices:0 to 254).

There is a regression update that will show the only change in the output png images is that values that were 254 with color value (0,0,0,0) are now 255 with color value (0,0,0,0).

Jira Issue ID

DAS-2280

Local Test Steps

Pull this image, build and run the tests, deploy to Harmony-In-A-Box for verifying the regression:

❯ ./bin/build-image && ./bin/build-test &&  ./bin/run-test

PR Acceptance Checklist

  • Jira ticket acceptance criteria met.
  • CHANGELOG.md updated to include high level summary of PR changes.
  • docker/service_version.txt updated if publishing a release.
  • Tests added/updated and passing.
  • Documentation updated (if needed).

Copy link
Collaborator

@lyonthefrog lyonthefrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the code for these small changes and noticed a couple things that are likely non-issues, but wanted to double check. The unit tests pass.
das-2280-unit-tests

CHANGELOG.md Outdated Show resolved Hide resolved
tests/unit/test_browse.py Show resolved Hide resolved
@flamingbear flamingbear merged commit d05dc65 into main Dec 20, 2024
7 checks passed
@flamingbear flamingbear deleted the mhs/DAS-2280/improve-singleband-processing branch December 20, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants