Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update harmony-service lib and update docker platform to amd64 #33
Update harmony-service lib and update docker platform to amd64 #33
Changes from all commits
75eb7cb
a36cbf5
cbaa9a8
45dbf82
2e1d99f
9157c95
3968086
7b9690a
2cc1867
7b70b3e
afc0d89
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are these actually valuable or just something we keep doing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good question. I was wondering something similar when I was updating the HGA
build-image
script. Basically, we're just recreating the commit history in the shell script, so probably they are not uniquely valuable.Perhaps the one minor value is where the script was originally copied from. But that said, we're trying to standardise, so that shouldn't really matter.
I'm entirely ambivalent beyond saying if we have these comments, they should be complete, or we should not have them. It would be a bit frustrating to have a log of changes to the file and then subsequent changes not captured in them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree. I'll pull them next time I visit (if I remember)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes me happy! I'm so grateful Danny pushed this change through.