DAS-2161: fix typo #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GDAL adds a NoData value to the png metadata when the colormap has 256 values and only one of those is transparent: RGBA(0,0,0,0). pillow 10.0.0 always returned a 256 length colormap from the quantized image irrespective of the number of colors requested. Pillow 10.x.0 changed this behavior to only return a palete of the unique values in the quantized image. By beginning with a 256-element all-black colortable and writing the truncated one over it, we retain the previous behavior which allows for some images to have a NoData Value in the PNG metadata.
See if it sticks.
owenlittlejohns
approved these changes
Jun 7, 2024
|
Closing this PR because I was just using it to test snyk and the typo is now fixed int #16 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes typo, but really testing snyk.
Jira Issue ID
DAS-2161
Local Test Steps
None