Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DAS-2166: Improve HyBIG documentation and notebooks #12
DAS-2166: Improve HyBIG documentation and notebooks #12
Changes from all commits
eb07718
4ce36f6
4c67ea1
a7ba93d
e55847e
67eff9e
38067a9
5f194ae
c95681b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding these missing items. (Although, now it's making me realise we're potentially missing the description of the license file in the list below, maybe the file is self-explanatory, but might be worth mentioning it's required for NASA open-source release)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I looked at all the files and was trying to decide which ones should be described. and with license it would be.
IDK. No strong opinions, but also don't think it's necessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think if we were to capture anything it would be that the license is in compliance with NASA open-source software requirements. Potential text:
Probably not perfect text, but I think that's the gist of anything I would add.