Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backup Api Key support #81

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Backup Api Key support #81

wants to merge 7 commits into from

Conversation

NFEL
Copy link

@NFEL NFEL commented Sep 21, 2023

No description provided.

@nanmu42
Copy link
Owner

nanmu42 commented Sep 22, 2023 •
edited
Loading

Cool.

Unfortunately the changes break existing APIs, which is undesirable.

Thanks for the hands-up.

@NFEL
Copy link
Author

NFEL commented Sep 25, 2023

Well, i thought you might say that, TBH. If you are interested, I can make some changes so the existing API's won't be effected.
e.g.

  • New -> NewWithBackup

@FournyP
Copy link

FournyP commented Oct 28, 2023

It can be a strong feature !

I'm agree to add this without affecting existing API's

@NFEL
Copy link
Author

NFEL commented Oct 29, 2023

So, if you can check and report which of existing apis are affected, I'd be happy to fix new code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NFEL @nanmu42 @FournyP