Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backend/enh/docker-push-for-ci #82

Merged
merged 1 commit into from
Sep 23, 2024
Merged

backend/enh/docker-push-for-ci #82

merged 1 commit into from
Sep 23, 2024

Conversation

vsaimanohar
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates

Description

Additional Changes

  • This PR modifies the database schema (database migration added)
  • This PR modifies dhall configs/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code and addressed linter errors ./dev/format-all-files.sh
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@vsaimanohar vsaimanohar force-pushed the backend/enh/docker-push-for-ci branch from c4be2f2 to 14a4dcd Compare September 20, 2024 11:19
@vsaimanohar vsaimanohar requested a review from srid September 20, 2024 11:20
@vsaimanohar vsaimanohar force-pushed the backend/enh/docker-push-for-ci branch 20 times, most recently from 9edead9 to b609487 Compare September 20, 2024 16:42
srid
srid requested changes Sep 20, 2024
View reviewed changes
.github/workflows/nix.yml Outdated Show resolved Hide resolved
.github/workflows/nix.yml Outdated Show resolved Hide resolved
.github/workflows/nix.yml Outdated Show resolved Hide resolved
.github/workflows/nix.yml Outdated Show resolved Hide resolved
.github/workflows/nix.yml Outdated Show resolved Hide resolved
@vsaimanohar vsaimanohar force-pushed the backend/enh/docker-push-for-ci branch 5 times, most recently from c88f40a to 5c9c984 Compare September 23, 2024 11:57
srid
srid requested changes Sep 23, 2024
View reviewed changes
Copy link
Member

@srid srid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just needs these two changes.

.github/workflows/nix.yml Outdated Show resolved Hide resolved
.github/workflows/nix.yml Outdated Show resolved Hide resolved
@srid
Copy link
Member

srid commented Sep 23, 2024

@vsaimanohar Can you also delete Jenkinsfile in this branch? So we officially migrate this repo to Github Actions as this PR is merged.

@vsaimanohar vsaimanohar force-pushed the backend/enh/docker-push-for-ci branch 2 times, most recently from 39e173e to 5cd5bee Compare September 23, 2024 21:30
@vsaimanohar vsaimanohar requested a review from srid September 23, 2024 21:31
@srid srid force-pushed the backend/enh/docker-push-for-ci branch from 96bde17 to a3b17ad Compare September 23, 2024 21:35
@srid srid merged commit 5ef3d86 into main Sep 23, 2024
1 check passed
@srid srid deleted the backend/enh/docker-push-for-ci branch September 23, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srid srid srid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vsaimanohar @srid