Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/remove city enum usage #81

Merged
merged 3 commits into from
Dec 30, 2024
Merged

Fix/remove city enum usage #81

merged 3 commits into from
Dec 30, 2024

Conversation

jaypalmudaliyar24
Copy link
Contributor

@jaypalmudaliyar24 jaypalmudaliyar24 commented Sep 6, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates

Description

  • Removes City enum usage across repository.
  • Added Update Cities API which can append or replace list of cities.
  • Related nammayatri PR

Additional Changes

  • This PR modifies the database schema (database migration added)
  • This PR modifies dhall configs/environment variables
  • Added internalAuthApiKey to add authentication in Update City API.

Motivation and Context

  • Because we require dependency update every time new City enum is added, it requires a new deployment otherwise immediate switch to this registry and gateway causes parsing issue. So made the city field across repo as Text which is expected to be the std code of city.
  • created api to update list of cities, so no db queries are required to update it.

How did you test it?

  • Tested locally and added relevant test in nammayatri repo.

Checklist

  • I formatted the code and addressed linter errors ./dev/format-all-files.sh
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@jaypalmudaliyar24 jaypalmudaliyar24 force-pushed the fix/remove-city-enum-usage branch 4 times, most recently from df0a496 to fd3319b Compare September 16, 2024 13:03
@jaypalmudaliyar24 jaypalmudaliyar24 force-pushed the fix/remove-city-enum-usage branch 2 times, most recently from fadbc3e to da08363 Compare September 17, 2024 16:50
@jaypalmudaliyar24 jaypalmudaliyar24 marked this pull request as ready for review September 19, 2024 15:28
@jaypalmudaliyar24 jaypalmudaliyar24 force-pushed the fix/remove-city-enum-usage branch from c41fbc7 to 77f06d8 Compare December 30, 2024 10:05
@NikithShetty NikithShetty merged commit 24da892 into main Dec 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants