Add Ubuntu Trust Store #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I remembered this today 😨 and I think I did it really badly/wrong |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This is an attempt at #3 . The content of certdata.txt is exactly the same as the url for the Mozilla trust store, except it's not the same in that it has a few more trusted certificates. As a result, I moved the parsing script you wrote along with the helper classes in the Mozilla Trust Store module to a separate file so we can use it for parsing the Ubuntu data as well. Originally I did copy paste between the modules aggressively but the tests started failing since both modules had their own version of CertdataEntryServerAuthTrustEnum, etc. which caused problems.
Let me know what you think!