Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/test label capitalization #3807

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions seaborn/_base.py
Original file line number Diff line number Diff line change
Expand Up @@ -384,8 +384,13 @@ def categorical_mapping(self, data, sizes, order):

if isinstance(sizes, dict):

# Dict inputs map existing data values to the size attribute
missing = set(levels) - set(sizes)
# Check for dict or defaultdict
missing = set()
for level in levels:
try:
sizes[level] # Ensure that default values are handled for defaultdict
except KeyError:
missing.add(level)
if any(missing):
err = f"Missing sizes for the following levels: {missing}"
raise ValueError(err)
Expand Down
2 changes: 1 addition & 1 deletion seaborn/categorical.py
Original file line number Diff line number Diff line change
Expand Up @@ -2669,7 +2669,7 @@ def countplot(
p.plot_data[count_axis] = 1

_check_argument("stat", ["count", "percent", "probability", "proportion"], stat)
p.variables[count_axis] = stat
p.variables[count_axis] = stat.capitalize()
if stat != "count":
denom = 100 if stat == "percent" else 1
p.plot_data[count_axis] /= len(p.plot_data) / denom
Expand Down
9 changes: 9 additions & 0 deletions tests/test_base.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
import pandas as pd
import matplotlib as mpl
import matplotlib.pyplot as plt
import seaborn as sns


import pytest
from numpy.testing import assert_array_equal, assert_array_almost_equal
Expand Down Expand Up @@ -1270,6 +1272,13 @@ def test_get_axes_single(self, long_df):
p._attach(ax)
assert p._get_axes({"hue": "a"}) is ax

def test_countplot_stat_label_capitalization(self, long_df):
data = sns.load_dataset("iris")
ax = sns.countplot(data=data, x="sepal_width", stat="count")

assert ax.get_ylabel() == "Count"
plt.close() # Cleanup

def test_get_axes_facets(self, long_df):

g = FacetGrid(long_df, col="a")
Expand Down
11 changes: 11 additions & 0 deletions tests/test_categorical.py
Original file line number Diff line number Diff line change
Expand Up @@ -3259,3 +3259,14 @@ def test_children(self, container):
children = container.get_children()
for child in children:
assert isinstance(child, mpl.artist.Artist)


def test_countplot_stat_label_capitalization():
import seaborn as sns
import matplotlib.pyplot as plt

data = sns.load_dataset("iris")
ax = sns.countplot(data=data, x="sepal_width", stat="count")

assert ax.get_ylabel() == "Count"
plt.close() # Cleanup