Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use proper method for accessing fields #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mrsylerpowers
Copy link

You are unable to override the fields method fully if this method is not used here

@matijakolaric
Copy link
Contributor

Hi, and thanks. I will be back early next week and have a look at this. I did a brief test, and the bug exists.

I think this will work, but I want to test it properly.

What you are using this for?

@mrsylerpowers
Copy link
Author

I am overriding this to make fields an instance variable instead of a class variable so that variable-length fields are supported. Using a deep copy of _fileds as an instance variable allows for the sizes of the fields to be changed on an instance basis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants