Fixes for RelayedV3 and Cookbook update #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||
| "cell_type": "markdown", | ||
| "metadata": {}, | ||
| "source": [ | ||
| "Additionally, we also have a method that combines the above methods and is able to identify the kind of transfer that we intend to perform based on it's parameters. The method can be used as follows:\n", |
examples/Cookbook.ipynb
Outdated
| "cell_type": "markdown", | ||
| "metadata": {}, | ||
| "source": [ | ||
| "Alternatively, the protocol now supports sending both native and esdt tokens in the same transaction. If a `native_amount` is provided together with `token_transfers`, the native token will also be included in the `MultiESDTNFTTrasfer` built-in function call." |
There was a problem hiding this comment.
"now supports" is somehow incorrect. It will support. If there is an already published page on docs, we can link to it. Otherwise, let's use the future tense.
There was a problem hiding this comment.
As far as I've seen, there is no docs page yet, but I've changed the text to be:
the protocol will support (in the very near future) sending ...
examples/Cookbook.ipynb
Outdated
| "source": [ | ||
| "### Relayed V3\n", | ||
| "\n", | ||
| "This is the latest iteration of relayed transactions and we highly recommend using this version over the previous ones." |
There was a problem hiding this comment.
Add a link to the official docs. And maybe rephrase to say "we recommend using this version ... as soon as it becomes available on the Network" (or something similar).
There was a problem hiding this comment.
changed the message and will add a link to the docs when that is available.
andreibancioiu
approved these changes
Jul 10, 2024
cristure
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.