Added ESDTTransferRole on fungible token #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreibancioiu
previously approved these changes
Apr 15, 2024
| @@ -283,14 +283,16 @@ def create_transaction_for_setting_special_role_on_fungible_token( | |||
| user: IAddress, | |||
| token_identifier: str, | |||
| add_role_local_mint: bool, | |||
| add_role_local_burn: bool | |||
| add_role_local_burn: bool, | |||
| add_role_esdt_transfer_role: bool | |||
There was a problem hiding this comment.
Breaking change, but we can live with it (there will be a minor version anyway).
ssd04
reviewed
Apr 15, 2024
| ) | ||
|
|
||
| assert transaction.data | ||
| assert transaction.data.decode() == "setSpecialRole@4652414e4b2d313163653365@1e8a8b6b49de5b7be10aaa158a5a6a4abb4b56cc08f524bb5e6cd5f211ad3e13@45534454526f6c654c6f63616c4d696e74@45534454526f6c654c6f63616c4275726e@455344545472616e73666572526f6c65" |
There was a problem hiding this comment.
i think it might be cleaner to have this expected value decomposed, to be able to see more easily that there is also ESDTTransferRole encoded
There was a problem hiding this comment.
maybe we can evaluate to have this pattern in all tests
ssd04
approved these changes
Apr 16, 2024
andreibancioiu
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added missing role according to this PR.