Updated price discovery #991
Open
+943
−1,939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage SummaryTotals
FilesExpand
|
|
Contract comparison - from 58a7e74 to 6eae83b
|
|
|
||
| ```rust | ||
| #[init] | ||
| fn init( | ||
| &self, | ||
| launched_token_id: TokenIdentifier, | ||
| accepted_token_id: TokenIdentifier, | ||
| accepted_token_id: EgldOrEsdtTokenIdentifier, |
There was a problem hiding this comment.
Ideally, use EgldOrEsdtTokenIdentifier for all args.
There was a problem hiding this comment.
Nah, you can't launch EGLD, so this makes it a bit more clear.
| bought_token_id: EgldOrEsdtTokenIdentifier<M>, | ||
| bought_token_amount: BigUint<M>, | ||
| pub struct OwnerDepositEvent<'a, M: ManagedTypeApi> { | ||
| token_amount_in: &'a BigUint<M>, |
There was a problem hiding this comment.
Lifetime of objects was hidden on purpose in the framework.
Is there a way to avoid this here?
There was a problem hiding this comment.
Nope. Lifetime is hidden when you call the respective helper functions, not when you define the struct.
| let min_launched_tokens = self.min_launched_tokens().get(); | ||
| let current_total_launched_tokens = self.launched_token_balance().get(); | ||
| require!( | ||
| ¤t_total_launched_tokens + &payment_amount >= min_launched_tokens, |
There was a problem hiding this comment.
Please use the same naming for variables.
current_total_launched_tokens, min_launched_tokens - change this to amount;
or
payment_amount - change this to tokens.
It's easier for the reviewer or the next developer to read and understand.
|
|
||
| fn owner_redeem(&self, owner: &ManagedAddress) -> EgldOrEsdtTokenPayment { | ||
| let launched_token_supply = self.launched_token_balance().get(); | ||
| require!( |
There was a problem hiding this comment.
This may be moved in the caller function redeem.
There was a problem hiding this comment.
No, I purposefully kept it in a different function.
| payment_result | ||
| } | ||
|
|
||
| /// Deposit ESDT received after deposit to withdraw the initially deposited tokens. |
There was a problem hiding this comment.
Correct this comment.
There was a problem hiding this comment.
I already did? What were you expecting the comment to say?
|
|
||
| self.burn_redeem_token(&payment_amount); | ||
| self.accepted_token_balance() | ||
| .update(|balance| *balance -= &payment_amount); |
There was a problem hiding this comment.
Verifiy that balance is greater than payment_amount.
There was a problem hiding this comment.
There's really no need for that. This should never fail, and even if it does, the framework has checks for BigUint diff being lower than 0.
psorinionut
reviewed
Jan 14, 2025
| require!(payment_token == &redeem_token_id, INVALID_PAYMENT_ERR_MSG); | ||
|
|
||
| let launched_token_supply = self.launched_token_balance().get(); | ||
| if launched_token_supply == 0 { |
There was a problem hiding this comment.
How could you get to this situation? What if launched_token_supply is > 0 but < than the SC balance?
There was a problem hiding this comment.
If the owner doesn't deposit any tokens. I'm not sure I get the second question? How would you ever reach such a situation?
| -> SingleValueMapper<BigUint>; | ||
| fn redeem_token_total_circulating_supply(&self) -> SingleValueMapper<BigUint>; | ||
|
|
||
| // TODO: Save launched token balance somewhere |
There was a problem hiding this comment.
Is this still relevant?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.