-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for user-defined control codes #108
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @vsrs)
src/service.rs
line 82 at r1 (raw file):
/// Can use user-defined control codes const NOTIFY = Services::SERVICE_USER_DEFINED_CONTROL;
Should we perhaps be consistent with the naming here? I.e., USER_DEFINED_CONTROL
in this case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 of 4 files reviewed, 1 unresolved discussion (waiting on @dlon)
src/service.rs
line 82 at r1 (raw file):
Previously, dlon (David Lönnhager) wrote…
Should we stick to naming these the same as the Windows constants? I.e.,
USER_DEFINED_CONTROL
in this case.
That makes sense, thank you. I've updated the code.
@dlon, may you please complete the review? Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
Thanks! |
Minor addition, no breaking changes.
This change is