Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WiX XML file and instructions #2695

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jasagredo
Copy link
Contributor

The Wix instructions are outdated (candle.exe and light.exe were unified in wix.exe) and the WXS file also was outdated.

❯ wix build scryer-prolog.wxs
C:\Users\Javier\scryer-prolog\scryer-prolog.wxs(2) : error WIX0199: The Wix element has an incorrect namespace of 'http://schemas.microsoft.com/wix/2006/wi'. Please make the Wix element look like the following: <Wix xmlns="http://wixtoolset.org/schemas/v4/wxs">.

❯ wix convert scryer-prolog.wxs
C:\Users\Javier\scryer-prolog\scryer-prolog.wxs : information WIX0005: [Converted] This file contains an XML declaration on the first line. (DeclarationPresent)
C:\Users\Javier\scryer-prolog\scryer-prolog.wxs(1) : information WIX0009: [Converted] The namespace 'http://schemas.microsoft.com/wix/2006/wi' is out of date. It must be 'http://wixtoolset.org/schemas/v4/wxs'. (XmlnsValueWrong)
C:\Users\Javier\scryer-prolog\scryer-prolog.wxs(2) : information WIX0023: [Converted] Using '*' for the Product Id attribute is unnecessary. Remove the attribute to remove the redundancy. (AutoGuidUnnecessary)
C:\Users\Javier\scryer-prolog\scryer-prolog.wxs(2) : information WIX0030: [Converted] The Product and Package elements have been renamed and reorganized for simplicity. (ProductAndPackageRenamed)
C:\Users\Javier\scryer-prolog\scryer-prolog.wxs : information WIX0058: [Converted] The TARGETDIR directory should no longer be explicitly defined. Remove the Directory element with Id attribute 'TARGETDIR'. (TargetDirDeprecated)
C:\Users\Javier\scryer-prolog\scryer-prolog.wxs(11) : information WIX0059: [Converted] Standard directories such as 'ProgramFilesFolder' should no longer be defined using the Directory element. Use the StandardDirectory element instead. (DefiningStandardDirectoryDeprecated)
C:\Users\Javier\scryer-prolog\scryer-prolog.wxs(18) : information WIX0059: [Converted] Standard directories such as 'ProgramMenuFolder' should no longer be defined using the Directory element. Use the StandardDirectory element instead. (DefiningStandardDirectoryDeprecated)

❯ wix build scryer-prolog.wxs

❯ ls scryer-prolog.msi -l
-rw-r--r-- 1 Javier Javier 3141632 Dec 10 23:50 scryer-prolog.msi

@jasagredo
Copy link
Contributor Author

@aarroyoc might be interested as the original author of the file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant