Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change apt-key because of deprecation #67

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

Spirit-act
Copy link
Contributor

Replace apt_key with an get_url and modified repo sources

Description

The apt-key functionality was deprecated and will be removed after ubuntu 24.04 and debian 12.

The simple solution is to download the key and work with the signed-by tag within the source list. I followed the installation guide from the official rabbitmq docs.

I also updated the rabbitmq-server version.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

I have a few questions about the Checklist:

  • What are the pre-merge tests? I have not found any.
  • I don't know what I should document an therefor I am not sure if I should check the point.
  • I have never worked with molecule and I do not see any tests which I could follow

After all I can say, I have deployed a RabbitMQ Cluster with these changes.

If anything should be changes, please make a comment.

apt-key was deprecated and will be removed after
ubuntu 24.04 and debian 12

The simple solution is to download the key and work with the signed-by
tag within the source list

Signed-off-by: Spirit-act <[email protected]>
Signed-off-by: Spirit-act <[email protected]>
Copy link

stale bot commented Nov 9, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Nov 9, 2024
@Spirit-act
Copy link
Contributor Author

I think the changes are still valid.

@stale stale bot removed the wontfix label Nov 12, 2024
@mrlesmithjr mrlesmithjr merged commit 7a75b2d into mrlesmithjr:master Nov 13, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants