Argument parsing changes + Code changes #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just a bit of cleanup of a few if statements at startup.
I made the arguments be passed as a hashmap and I changed a few things so they are easier to read.
So main.c looked less cluttered.
Push speed was accidentally missed while making the argument parser.
Added a bit of ascii styling to the help menu, added a contributors section, added the arguments, and added borders etc.
accidentally placed this file inside of the root directory instead of under assets
accidentally placed this file inside of the root directory instead of under assets
|
Looks good! Those are some good contributions thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pull:
I have changes an if statement to a switch statement, this made it easier to read and potentially increased performance.
I did an overhaul of how arguments where read by the program. Now arguments are looked up on a switch with hashes. This allows for more efficient scaling, faster checks, and enables a more modular approach. Hashes can be calculated with the inbuilt tool that is called with ./tuxpusher -gh {STRINGTOBEHASHED}
I separate the help menu from main.c and placed it in the assets folder. I also changed the look of it to reflect the new changes.
Please note, I'm currently only using github's website at the moment and it (to my knowledge) does not allow me to undo commits, that's why console_menus.h was relocated etc.