-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
command: make playlist-play-index accept file-local-options #15608
base: master
Are you sure you want to change the base?
command: make playlist-play-index accept file-local-options #15608
Conversation
Download the artifacts for this pull request: |
Works like loadfile. The documentation is copied from it. This allows reloading the current file from the same time-pos without hacks.
95bf058
to
f1fa7ab
Compare
@@ -474,7 +474,7 @@ Playlist Manipulation | |||
Go to the first of the previous entries on the playlist with a different | |||
``playlist-path``. | |||
|
|||
``playlist-play-index <integer|current|none>`` | |||
``playlist-play-index <integer|current|none> [<options>]`` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens if options were added with loadfile
already? Why we need to duplicate it in play command?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are just merged with any previous file-local-options. The use case for this was that I wrote a format quality selector, then realized it's useless since you can set --script-opt=ytdl_hook-all_formats=yes
and use regular track selection much more quickly without rerunning yt-dlp, but still in that selector I would do playlist-play-index current start=${time-pos}
to restart the stream from the same position. Hackier alternatives are write-watch-later-config; playlist-play-index current
, or using this temporary event listener https://github.com/christoph-heinrich/mpv-quality-menu/blob/6e4dc5ee8d41b422239ae504c52647a1478675b7/quality-menu.lua#L245. Again I don't know if this is worth adding regardless. Though maybe we can bind ctrl+r to a builtin script using this for general purpose refresh of the current URL, if that's worth it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I did not think of this because I use --watch-later-options=start
, but write-watch-later-config; playlist-play-index current
will also preserve --watch-later-options
other than start
. So maybe it's better to just use that.
Works like loadfile. The documentation is copied from it.
This allows reloading the current file from the same time-pos without hacks.
Not sure if this is worth it.