Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

command: make playlist-play-index accept file-local-options #15608

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

guidocella
Copy link
Contributor

Works like loadfile. The documentation is copied from it.

This allows reloading the current file from the same time-pos without hacks.

Not sure if this is worth it.

Copy link

github-actions bot commented Jan 1, 2025

Download the artifacts for this pull request:

Windows
macOS

Works like loadfile. The documentation is copied from it.

This allows reloading the current file from the same time-pos without
hacks.
@guidocella guidocella force-pushed the playlist-play-index-options branch from 95bf058 to f1fa7ab Compare January 1, 2025 10:17
@@ -474,7 +474,7 @@ Playlist Manipulation
Go to the first of the previous entries on the playlist with a different
``playlist-path``.

``playlist-play-index <integer|current|none>``
``playlist-play-index <integer|current|none> [<options>]``
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if options were added with loadfile already? Why we need to duplicate it in play command?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are just merged with any previous file-local-options. The use case for this was that I wrote a format quality selector, then realized it's useless since you can set --script-opt=ytdl_hook-all_formats=yes and use regular track selection much more quickly without rerunning yt-dlp, but still in that selector I would do playlist-play-index current start=${time-pos} to restart the stream from the same position. Hackier alternatives are write-watch-later-config; playlist-play-index current, or using this temporary event listener https://github.com/christoph-heinrich/mpv-quality-menu/blob/6e4dc5ee8d41b422239ae504c52647a1478675b7/quality-menu.lua#L245. Again I don't know if this is worth adding regardless. Though maybe we can bind ctrl+r to a builtin script using this for general purpose refresh of the current URL, if that's worth it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I did not think of this because I use --watch-later-options=start, but write-watch-later-config; playlist-play-index current will also preserve --watch-later-options other than start. So maybe it's better to just use that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants