This repository has been archived by the owner on Apr 17, 2021. It is now read-only.
Closes #2988: Remove Pocket from NavigationOverlay #2994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcomella
suggested changes
Jun 26, 2020
There was a problem hiding this comment.
The code makes sense – remove the model (the fetch) and the UI – but I have difficulty feeling confident in the change if the code is still around in the APK, just in case there's a reference we missed. Can you remove the classes (which shouldn't have any utility anymore, afaict)?
After that, lgtm. If I'm not around to do the second review pass, someone else should be able to double check this and I think we'd be good.
To verify the behavior, I loaded it up in the Android TV emulator and moved my cursor around. I was unable to verify the a11y changes because I do not have a device: please make sure this is tested and that QA has tested it as well! Thanks.
app/src/main/java/org/mozilla/tv/firefox/navigationoverlay/NavigationOverlayFragment.kt
Show resolved
Hide resolved
mcomella
suggested changes
Jun 26, 2020
app/src/main/java/org/mozilla/tv/firefox/webrender/CustomContentRequestInterceptor.kt
Show resolved
Hide resolved
app/src/test/java/org/mozilla/tv/firefox/architecture/FirefoxViewModelProvidersTest.kt
Show resolved
Hide resolved
app/src/test/java/org/mozilla/tv/firefox/webrender/WebRenderHintViewModelTest.kt
Show resolved
Hide resolved
psymoon
force-pushed
the
remove-pocket
branch
2 times, most recently
from
9c45a9b to
1ace39c
Compare
mcomella
approved these changes
Jun 26, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
qa-readyorqa-notneeded)