Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve test coverage #462

Merged
merged 105 commits into from
Jun 17, 2024
Merged

Improve test coverage #462

merged 105 commits into from
Jun 17, 2024

Conversation

dividehex
Copy link
Contributor

This PR is focused on adding test coverage and refactoring rules as needed.

@dividehex
major fixes
f97c86f
@dividehex
Fix the mozilla logo image link in the passwordless email
bfea828
@dividehex
Remove original_connection_user_id namespaced claim
2dcb795
@dividehex
Update package.json
6052778 
        This commit updates package.json to include new tools for
        testing.  Including c8, jest mock fetch.  This also moves the
        package.json and package-lock.json to root dir.
@dividehex
GHA run tests in root dir
48fcf2b
@dividehex
Fix a couple test file names so they actually run
664237d
@dividehex
return _ in the callback handler
6501b4b
@dividehex
Make sure callback is always returned in OIDC-conformance-workaround …
3d17510 
…rule
@dividehex
Expand OIDC-conformance-workaround rule test
40d00f7
@dividehex
Expand the test for default-deny-for-maintenance rule
1cc375f
@dividehex
Be more explict and check the url on the default-deny-for-maintenance…
ef50eb7 
… test
@dividehex
Lint and clean up SAML-Braintree-attribute rule
3b4964d
@dividehex
Expand test coverage for SAML-Braintree-attribute rule
3d48323
@dividehex
Lint and clean up SAML-Navex-partition-id rule
3ef0288
@dividehex
Expand test coverage for SAML-Navex-partition-id rule
2dfead6
@dividehex
Lint and clean up SAML-gcp-gsuite rule
80c5856
@dividehex
Expand test coverage for SAML-gcp-gsuite rule
fa3906b
@dividehex
Lint and clean up SAML-lgtm rule
1f079e3
@dividehex
Expand test coverage for SAML-lgtm rule
d8854e9
@dividehex
Lint and clean up SAML-test-mozilla-com-google rule
4bc1a87
@dividehex
Expand test coverage for SAML-test-mozilla-com-google rule
73250be
@dividehex
Lint and clean up aai rule
2609173
@dividehex
Expand test coverage for aai rule
9bccc29
@dividehex
Expand test coverage for CIS-Claims-fixup rule
b85a93c
@dividehex
Lint and clean up Global-Function-Declarations rule
c8fa42d
@dividehex
Mock the UnauthorizedError object and return the global object in the…
e190df0 
… callback handler
@dividehex
Expand test coverage for Global-Function-Declarations rule
ec9a8ff
@dividehex
Remove SAML-Convercent-Community rule and tests
9a22e52
@dividehex
Add test coverage for SAML-vectra rule
ff1ed6a
@dividehex
Convert all sync tests to async
fb85d6a
dividehex added 21 commits May 31, 2024 11:11
@dividehex
Mock the UnauthorizedError object and return the global object in the…
ee9cced 
… callback handler
@dividehex
Expand test coverage for Global-Function-Declarations rule
9465340
@dividehex
Remove SAML-Convercent-Community rule and tests
c4e5a3f
@dividehex
Add test coverage for SAML-vectra rule
e22c9c9
@dividehex
Convert all sync tests to async
39ecebe
@dividehex
Fix up the rule loader
bf24822 
        * add prettier to lint and format function text
        * convert the rule function wrapper to an async function
        * strip any requires of fetch in favor for passing a mocked
          version of fetch to the function
@dividehex
Rewrite AccessRules.js and add test coverage for it
d25c52c
@dividehex
Clean up and lint rules/GHE-Groups.js
b8a6032
@dividehex
Missing semicolon
0252df8
@dividehex
Add some env vars to configuration object needed for GHE-Groups rules
2c224aa
@dividehex
Fix test in force-ldap-logins-over-ldap.test.js
1ef1784
@dividehex
Return _log as standalone object instead of inside the context object
2e90c54
@dividehex
Refactor and use async/await in rules/GHE-Groups.js for clarity and r…
0eee0f7 
…eadability
@dividehex
Add test coverage for GHE-Groups.js
f0b9669
@dividehex
Add a mock function for auth0.updateUserMetadata
c092ec6
@dividehex
Add environment vars to the configuration object needed for unittests
c73f803
@dividehex
Refactor rules/activate-new-users-in-CIS.js for better error handlein…
b48f1a2 
…g and readability
@dividehex
Expand on tests/activate-new-users-in-CIS.test.js for better test cov…
0760522 
…erage
@dividehex
Merge remote-tracking branch 'dividehex/better_tests' into better_tests
d3e5f6a
@dividehex
Removes missed merge markers
b3c05ff
@dividehex
Update GHE-groups tests to include latest client_ids
e445192
@dividehex dividehex marked this pull request as ready for review May 31, 2024 16:16
@dividehex dividehex requested a review from frosemond May 31, 2024 16:16
@dividehex
Copy link
Contributor Author

This PR is currently deployed to dev where it is being exercised and tested.

@floatingatoll
Copy link
Contributor

(Adding an r+ in case GitHub is wedged; I've been monitoring these change sets and it looks good.)

@dividehex dividehex merged commit 5903b26 into mozilla-iam:master Jun 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frosemond frosemond frosemond approved these changes

@floatingatoll floatingatoll floatingatoll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dividehex @floatingatoll @frosemond