This repository has been archived by the owner on Jun 6, 2024. It is now read-only.
time-based slots and non-parachain support #58
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@librelois I wonder if you would be willing to look at my code here for a few minutes. I am really close to having nimbus work in non-parachain context. But I am stuck on a lifetime issue. EDIT: Nevermind, it was just a silly mistake. But writing a question to you really seemed to get me unstuck :) |
|
Okay, this is basically working. From here on it is just cleanup and refactoring. |
|
@JoshOrndorff can you merge master then tag me when it's done, then I'll review :) |
|
Sorry, I don't have time for this now. I had time for it six months ago. Plus I don't know how it will interact with the vrf-related changes that have gone in in the meantime. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #3
This PR (currently WIP) adds an implementation of Substrates
SlotWorkertrait that works with Nimbus.This will allow standalone blockchains (not parachains) to use nimbus in production.
This PR will also add an example of using nimbus in this way in the template node.