Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v2.0.4 #455

Merged
merged 23 commits into from
Nov 20, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
23589da
Next development iteration `2.0.4-SNAPSHOT`.
ielis Aug 1, 2023
323f98b
Setup benchmark stubs.
ielis Oct 31, 2023
a8de4e1
Refactor `CsrOntologyGraph` to `CsrPolyOntologyGraph`.
ielis Oct 31, 2023
312ad5a
Implement `CsrMonoOntologyGraph`. Fix bug in `CsrPolyOntologyGraph` t…
ielis Nov 1, 2023
094eaff
Expose mono CSR builder through `OntologyGraphBuilders`.
ielis Nov 1, 2023
6a470a0
Setup benchmark for poly vs. mono. Use mono by default in `MinimalOnt…
ielis Nov 1, 2023
474ffa7
Use hash map instead of binary search. Extend benchmarks.
ielis Nov 1, 2023
c537d92
Add bench results
ielis Nov 1, 2023
4c9538b
Set max line length to 120.
ielis Nov 3, 2023
1330cbf
Improve documentation and logging.
ielis Nov 3, 2023
2076007
Update documentation on `TermAnnotation`.
ielis Nov 4, 2023
e2173f1
Implement sub ontology in mono graph.
ielis Nov 6, 2023
5461204
Implement sub ontology in poly graph.
ielis Nov 12, 2023
3f80ec2
Add comprehensive tests of the subgraph. Fix CSR data bug. Remove met…
ielis Nov 13, 2023
0746f2f
Simplify `CsrPolyOntologyGraph`.
ielis Nov 13, 2023
25e82ac
Add `subOntology` tests, update meta info.
ielis Nov 13, 2023
c985368
Improve subontology test.
ielis Nov 13, 2023
cac1441
Merge pull request #451 from monarch-initiative/petty-fixes
ielis Nov 13, 2023
52a5291
Update the dependencies, remove unnecessary guava module and code.
ielis Nov 13, 2023
b424eac
Merge pull request #448 from monarch-initiative/mono-graph
ielis Nov 20, 2023
9717e7f
Merge pull request #453 from monarch-initiative/sub-ontology-graph
ielis Nov 20, 2023
2a5291d
Merge pull request #454 from monarch-initiative/#449-update-dependencies
ielis Nov 20, 2023
4fdfd30
Set version to `2.0.4`, update changelog.
ielis Nov 20, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .editorconfig
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
[*]
indent_style = space
indent_size = 2
max_line_length = 120
trim_trailing_whitespace = true
insert_final_newline = true
12 changes: 12 additions & 0 deletions CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,18 @@ Changelog
latest
------

-----
2.0.4
-----

Minor release, no breaking changes.

- Fix broken implementation of `MinimalOntology.subOntology` method.
- Simplify implementation of CSR adjacency matrix that backs `OntologyGraph` by default.
- Improve `OntologyGraph` test coverage.
- Add microbenchmark to benchmark the ontology loading.
- Update dependencies, remove Guava usage.

------
2.0.3
------
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ associate phenotype annotation files.

- **Language/Platform:** Java >=11
- **License:** BSD 3-Clause Clear
- **Version:** 2.0.3
- **Version:** 2.0.4
- **Authors:**
- Sebastian Bauer
- Peter N. Robinson
Expand All @@ -39,7 +39,7 @@ We recommend indicating the phenol version in the `properties` section of the po
```
<properties>
(...)
<phenol.version>2.0.3</phenol.version>
<phenol.version>2.0.4</phenol.version>
</properties>
```

Expand Down
2 changes: 1 addition & 1 deletion docs/conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
# The short X.Y version.
version = '2.0'
# The full version, including alpha/beta/rc tags.
release = '2.0.3'
release = '2.0.4'

# -- General configuration ---------------------------------------------------
# https://www.sphinx-doc.org/en/master/usage/configuration.html#general-configuration
Expand Down
2 changes: 1 addition & 1 deletion phenol-analysis/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<parent>
<groupId>org.monarchinitiative.phenol</groupId>
<artifactId>phenol</artifactId>
<version>2.0.3</version>
<version>2.0.4</version>
</parent>

<artifactId>phenol-analysis</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion phenol-annotations/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<parent>
<groupId>org.monarchinitiative.phenol</groupId>
<artifactId>phenol</artifactId>
<version>2.0.3</version>
<version>2.0.4</version>
</parent>

<artifactId>phenol-annotations</artifactId>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
package org.monarchinitiative.phenol.annotations.formats.mpo;


import com.google.common.collect.ImmutableSet;
import org.junit.jupiter.api.Test;
import org.monarchinitiative.phenol.ontology.data.TermId;

Expand All @@ -15,7 +14,7 @@ public class MpAnnotationTest {
@Test
public void testAnnotationTypeString() {
TermId mpId = TermId.of("MP:123");
Set<String> pmids = ImmutableSet.of();
Set<String> pmids = Set.of();
MpAnnotation.Builder builder = new MpAnnotation.Builder(mpId,pmids).sexSpecific(MpSex.FEMALE);
MpAnnotation annot = builder.build();
String expected = "MP:123FEMALE_SPECIFIC_ABNORMAL";
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package org.monarchinitiative.phenol.annotations.hpo;

import com.google.common.collect.ImmutableSet;
import org.junit.jupiter.api.BeforeAll;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;
Expand Down Expand Up @@ -84,14 +83,14 @@ void testNumberOfAnnotationsPostmerge() {
}
assertNotNull(anophthalmiaEntry);
assertEquals(expectedFrequency,anophthalmiaEntry.getFrequencyModifier());
Set<String> expectedBiocuration= ImmutableSet.of("HP:probinson[2018-05-28]","HP:probinson[2019-05-28]");
Set<String> expectedBiocuration= Set.of("HP:probinson[2018-05-28]","HP:probinson[2019-05-28]");
String actualBiocuration=anophthalmiaEntry.getBiocuration();
String[] bioc=actualBiocuration.split(";");
for (String biocurationItem : bioc) {
assertTrue(expectedBiocuration.contains(biocurationItem));
}

Set<String> expectedPublication=ImmutableSet.of("PMID:3214","PMID:1234");
Set<String> expectedPublication=Set.of("PMID:3214","PMID:1234");
String actualPub=anophthalmiaEntry.getPublication();
String []pubs=actualPub.split(";");
for (String pub:pubs) {
Expand Down
2 changes: 1 addition & 1 deletion phenol-cli/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<parent>
<groupId>org.monarchinitiative.phenol</groupId>
<artifactId>phenol</artifactId>
<version>2.0.3</version>
<version>2.0.4</version>
</parent>

<artifactId>phenol-cli</artifactId>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

@CommandLine.Command(name = "phenol demo",
mixinStandardHelpOptions = true,
version = "2.0.3",
version = "2.0.4",
description = "phenol demo programs")
public class Main implements Callable<Integer> {
private static final Logger LOGGER = LoggerFactory.getLogger(Main.class);
Expand Down
2 changes: 1 addition & 1 deletion phenol-core/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<parent>
<groupId>org.monarchinitiative.phenol</groupId>
<artifactId>phenol</artifactId>
<version>2.0.3</version>
<version>2.0.4</version>
</parent>

<artifactId>phenol-core</artifactId>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,11 @@ default boolean isDescendantOf(T subject, T object) {
return runQuery(t -> getDescendants(t, false), subject, object);
}

/**
* Get the subgraph with {@code subRoot} as the new root node.
*/
OntologyGraph<T> extractSubgraph(T subRoot);

/**
* Get the number of nodes in the graph.
*
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
package org.monarchinitiative.phenol.graph;


import org.monarchinitiative.phenol.graph.csr.CsrOntologyGraphBuilder;
import org.monarchinitiative.phenol.graph.csr.mono.CsrMonoOntologyGraphBuilder;
import org.monarchinitiative.phenol.graph.csr.poly.CsrPolyOntologyGraphBuilder;
import org.monarchinitiative.phenol.ontology.data.TermId;

/**
Expand Down Expand Up @@ -31,7 +32,15 @@ private OntologyGraphBuilders(){}
*
*/
public static <E> OntologyGraphBuilder<TermId> csrBuilder(Class<E> clz) {
return CsrOntologyGraphBuilder.builder(clz);
return CsrPolyOntologyGraphBuilder.builder(clz);
}

/**
* Get an {@link OntologyGraphBuilder} for building a simple graph with one edge type backed by a CSR-like
* data structure.
*/
public static OntologyGraphBuilder<TermId> monoCsrBuilder() {
return CsrMonoOntologyGraphBuilder.builder();
}

}

This file was deleted.

Loading
Loading