feat: reconcile 2.0, event streams, version enforcement #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Meshiest
changed the title
…esis block reconciler
…cile into set_agent_state, add EnvInfo lite for agents, remove dead code
…tatus structs to common
Meshiest
changed the title
…num structures for json
…bincode is begone
gluax
approved these changes
Dec 5, 2024
| *self.last_node_status.write().await = status.map(|s| (Instant::now(), s)); | ||
| } | ||
|
|
||
| pub async fn get_node_status(&self) -> Option<SnarkOSStatus> { |
There was a problem hiding this comment.
Couldn't this be a reference? Or is needed as a non-reference where it's called?
There was a problem hiding this comment.
I think it would have to be the RwLock's guard type, which felt kinda weird. Any references would be temporary
This was referenced Dec 6, 2024
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tasks:
[ ] potentially start tests on reconcile 2.0 behavior(need to make a new task for making all of snops more testable, with the controlplane not needing to run axum for each api to be tested)related: