fix: common compiling, clippy and fmt fixes

monadicus · Dec 7, 2024 · 12e70bd · 12e70bd
1 parent 99e6771
commit 12e70bd
Show file tree

Hide file tree

Showing 7 changed files with 7 additions and 8 deletions.
diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml
@@ -5,8 +5,8 @@ on:
 env:
   CARGO_TERM_COLOR: always
   RUST_BACKTRACE: 1
-  # https://releases.rs/docs/1.82.0/ release date
-  NIGHTLY_TOOLCHAIN: nightly-2024-10-17
+  # https://releases.rs/docs/1.83.0/ release date
+  NIGHTLY_TOOLCHAIN: nightly-2024-11-28
 
 # Cancel in progress workflows on pull_requests.
 # https://docs.github.com/en/actions/using-jobs/using-concurrency#example-using-a-fallback-value

diff --git a/crates/agent/src/reconcile/storage.rs b/crates/agent/src/reconcile/storage.rs
@@ -205,7 +205,7 @@ pub struct LedgerReconciler<'a> {
     pub modify_handle: &'a mut Option<(AbortHandle, Arc<Mutex<Option<LedgerModifyResult>>>)>,
 }
 
-impl<'a> LedgerReconciler<'a> {
+impl LedgerReconciler<'_> {
     pub fn untar_paths(&self) -> (PathBuf, &'static str) {
         if self.env_info.storage.persist {
             (

diff --git a/crates/aot/src/accounts.rs b/crates/aot/src/accounts.rs
@@ -38,7 +38,7 @@ pub const BECH32M_CHARSET: &str = "0123456789acdefghjklmnpqrstuvwxyz";
 #[derive(Clone, Copy)]
 struct VanityCheck<'a>(&'a [bech32::u5]);
 
-impl<'a> bech32::WriteBase32 for VanityCheck<'a> {
+impl bech32::WriteBase32 for VanityCheck<'_> {
     type Err = bool;
 
     fn write_u5(&mut self, data: bech32::u5) -> std::result::Result<(), Self::Err> {

diff --git a/crates/common/Cargo.toml b/crates/common/Cargo.toml
@@ -21,7 +21,7 @@ clap_mangen = { workspace = true, optional = true }
 clap-markdown = { workspace = true, optional = true }
 fixedbitset = { workspace = true, optional = true }
 futures.workspace = true
-http.workspace = true
+http = { workspace = true, features = ["std"] }
 indexmap = { workspace = true, features = ["std", "serde"] }
 lasso.workspace = true
 lazy_static.workspace = true
@@ -40,7 +40,7 @@ tarpc.workspace = true
 thiserror.workspace = true
 tokio = { workspace = true, features = ["process"] }
 tracing.workspace = true
-url.workspace = true
+url = { workspace = true, features = ["serde"] }
 wildmatch.workspace = true
 
 [dev-dependencies]

diff --git a/crates/common/src/key_source.rs b/crates/common/src/key_source.rs
@@ -45,7 +45,7 @@ impl<'de> Deserialize<'de> for KeySource {
     {
         struct KeySourceVisitor;
 
-        impl<'de> Visitor<'de> for KeySourceVisitor {
+        impl Visitor<'_> for KeySourceVisitor {
             type Value = KeySource;
 
             fn expecting(&self, formatter: &mut fmt::Formatter) -> fmt::Result {

diff --git a/crates/common/src/schema/mod.rs b/crates/common/src/schema/mod.rs
@@ -10,7 +10,6 @@ pub mod cannon;
 pub mod error;
 pub mod nodes;
 pub mod persist;
-pub mod serialize;
 pub mod storage;
 
 // TODO: Considerations:

diff --git a/crates/common/src/schema/serialize.rs b/crates/common/src/schema/serialize.rs