Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define order within legend and plotting order #3483

Merged
merged 3 commits into from
Feb 28, 2024
Merged

Define order within legend and plotting order #3483

merged 3 commits into from
Feb 28, 2024

Conversation

henrikt-ma
Copy link
Collaborator

Fixes #3475.

otronarp
otronarp approved these changes Feb 21, 2024
View reviewed changes
Copy link
Member

@otronarp otronarp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

DagBruck
DagBruck approved these changes Feb 25, 2024
View reviewed changes
Copy link
Collaborator

@DagBruck DagBruck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand. That's good enough for me.

@henrikt-ma
Copy link
Collaborator Author

Requesting new reviews after addressing @eshmoylova's comment regarding lack of symmetry with the description of graphical annotations.

@HansOlsson HansOlsson merged commit b1261e7 into modelica:master Feb 28, 2024
1 check passed
@henrikt-ma henrikt-ma deleted the curve-z-order branch February 28, 2024 10:04
@HansOlsson HansOlsson added the M37 For pull requests merged into Modelica 3.7 label May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DagBruck DagBruck DagBruck approved these changes

@eshmoylova eshmoylova eshmoylova approved these changes

@otronarp otronarp otronarp approved these changes

Assignees
No one assigned
Labels
M37 For pull requests merged into Modelica 3.7
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Plotting order
5 participants
@henrikt-ma @otronarp @eshmoylova @DagBruck @HansOlsson