-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add optional param for passing a custom logger to ChargePoint #641
Conversation
HI @hhuseyinpay, can you update the PR with the required formatting. Single quotes ( |
done |
Can you please update the respective line? |
There are still some formatting issues. It seems like the New line character is different from what is expected by the code quality check, cause all the visible characters are the same. |
I don't know how to do that. I use Pycharm with default settings |
A simple google search may give you this: |
Some more formatting issues. |
I've spent enough time on this. I'm no longer interested in this. You can easily make these changes yourself. If formatting is that important, consider writing a simple pre-commit script. |
This pull request introduces a
logger
parameter to theChargePoint
class's__init__
function. This allows users to specify a custom logger, enhancing flexibility and control over logging.