Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ChargePoint._handle_call return response #538

Merged
merged 3 commits into from
Dec 7, 2023
Merged

ChargePoint._handle_call return response #538

merged 3 commits into from
Dec 7, 2023

Conversation

wafa-yah
Copy link
Contributor

@wafa-yah wafa-yah commented Dec 1, 2023 •
edited
Loading

  • To log OCPP call results to ocpp_index, we are currently relying on a decorator that decorates the _on_action handlers.
  • At the level of those handlers we do not have access to the message.unique_id which is a logging requirement, for that we decided to use ChargePoint._handle_call method.
  • By doing so we lost access to the response which is also a required field for the logging.
  • To resolve this, we want to make ChargePoint._handle_call has the response as return value.

@wafa-yah wafa-yah requested a review from OrangeTux as a code owner December 1, 2023 13:53
@wafa-yah wafa-yah self-assigned this Dec 1, 2023
@Jared-Newell-Mobility Jared-Newell-Mobility changed the title [CHAR-3326] ChargePoint._handle_call return response ChargePoint._handle_call return response Dec 6, 2023
@wafa-yah wafa-yah force-pushed the CHAR-3326-return_value_in_charger_point_handle_call branch from e8b23b2 to a031ca4 Compare December 7, 2023 08:47
@wafa-yah wafa-yah merged commit 268dc85 into master Dec 7, 2023
6 checks passed
@wafa-yah wafa-yah deleted the CHAR-3326-return_value_in_charger_point_handle_call branch December 7, 2023 09:41
@wafa-yah wafa-yah mentioned this pull request Dec 7, 2023
Closed
ajmirsky pushed a commit to ajmirsky/ocpp that referenced this pull request Nov 26, 2024
@wafa-yah
ChargePoint._handle_call return response (mobilityhouse#538)
3f4c9ee 
Make `ChargePoint._handle_call` has the
response` as return value.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jared-Newell-Mobility Jared-Newell-Mobility Jared-Newell-Mobility approved these changes

@OrangeTux OrangeTux Awaiting requested review from OrangeTux

Assignees

@wafa-yah wafa-yah

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wafa-yah @Jared-Newell-Mobility